Replaced help button #1544
Merged
Replaced help button #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nivida
suggested changes
Feb 12, 2021
nivida
left a comment
There was a problem hiding this comment.
The changes look good to me. But I think we can remove the HelpScoutBeacon component at all other places of the client as well. Feel free to verify this with @joeycharlesworth
|
Agreed, the HelpScoutBeacon component should be removed from other places
too.
…On Fri, Feb 12, 2021 at 2:27 PM Samuel Furter ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The changes look good to me. But I think we can remove the HelpScoutBeacon
component at all other places of the client as well. Feel free to verify
this with @joeycharlesworth <https://github.com/joeycharlesworth>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1544 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4XIDQSWDD5ADNNOVTX7ILS6U3E3ANCNFSM4XPRMTAQ>
.
|
nivida
approved these changes
Feb 17, 2021
WissenIstNacht
added a commit
that referenced
this pull request
Feb 24, 2021
This reverts commit 1f16b0f.
WissenIstNacht
added a commit
that referenced
this pull request
Feb 24, 2021
* Replaced help button * Removed Help Beacon from codebase * additional vercel configuration to prevent minification * widget through app * widget through app 2 * trying widgetloader * trying widgetloader fixed string * hosted widget loader * cleaned up code * fixed formatting * Revert "Replaced help button (#1544)" This reverts commit 1f16b0f. * satisfy linter * satisfy linter pt 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the bottom-right help button with a sticker for an interactive ticket service.