Skip to content

Add -json output flag to list|show commands #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbolla merged 7 commits into from
Sep 24, 2021
Merged

Add -json output flag to list|show commands #976

lbolla merged 7 commits into from
Sep 24, 2021

Conversation

@freakinhippie
Copy link
Contributor

@freakinhippie freakinhippie commented Sep 16, 2021

Signed-off-by: Joshua Colson joshua.colson@gmail.com

Fixes #

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

This PR is to add a -json flag to format the output of list and show commands in JSON.

Note: this initial commit is a WIP with only relevant updates to the repo command to solicit feedback before coding for mirror, publish, and snapshot.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@freakinhippie
Add -json output flag to repo list|show
60a25dd 
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
@freakinhippie freakinhippie marked this pull request as draft September 16, 2021 16:33
@freakinhippie
Copy link
Contributor Author

freakinhippie commented Sep 16, 2021

@lbolla Would you or someone from the team be able to provide some feedback on this draft PR? I'd like to course correct sooner rather than later if there are significant problems.

Thanks.

lbolla
lbolla reviewed Sep 17, 2021
View reviewed changes
@freakinhippie
Refactor repo list into json and txt output
a23b932 
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
@freakinhippie
Add -json flag to snapshot show|list
9576f3c 
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
@freakinhippie
Add Debian 11 keys to test fixture keyring
3d9f0db 
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
@freakinhippie
Add -json flag to mirror list|show
ddef8eb 
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
@freakinhippie
Add -json flag to publish list|show
9ed72e3 
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
@freakinhippie freakinhippie changed the title Add -json output flag to list|show commands WIP Add -json output flag to list|show commands Sep 22, 2021
@freakinhippie freakinhippie marked this pull request as ready for review September 22, 2021 01:48
@freakinhippie
Copy link
Contributor Author

freakinhippie commented Sep 22, 2021

@lbolla I think this PR is ready for review. Thanks.

lbolla
lbolla suggested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@lbolla lbolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I just added some minor comments.

@freakinhippie
Resolve PR aptly-dev#976 review comments
78ff3a3 
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
@freakinhippie
Copy link
Contributor Author

freakinhippie commented Sep 22, 2021

@lbolla What is the process for aptly releases? Is there any hope for this making it into a release in the near future?

lbolla
lbolla approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@lbolla lbolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lbolla lbolla merged commit 0bc6603 into aptly-dev:master Sep 24, 2021
@lbolla
Copy link
Contributor

lbolla commented Sep 24, 2021

@lbolla What is the process for aptly releases? Is there any hope for this making it into a release in the near future?

We haven't done a release yet since when we inherited maintenance of this project. As far as I know, releases were made with Travis, which is broken (see #973). We may figure out how to release manually in the meantime.

@randombenj randombenj added this to the 1.5.0 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lbolla lbolla lbolla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@freakinhippie @lbolla @randombenj