Feat add builds worker #2675
Feat add builds worker #2675
Conversation
|
|
||
| protected function triggerBuildStage(string $projectId, string $buildId) | ||
| { | ||
| // TODO: What is a reasonable time to wait for a build to complete? |
There was a problem hiding this comment.
What should be a reasonable timeout for this ?
We're in the builds worker here. Does it matter if this request takes 900 seconds to complete? The rest of the builds will be queued in the meantime
There was a problem hiding this comment.
It really varies with builds from rust taking up to 20 minutes on slow hardware. Could we make it a environment variable?
…e into feat-add-builds-worker
…e into feat-add-builds-worker
| $function = $dbForProject->getDocument('functions', $functionId); | ||
|
|
||
| // Request executor to delete deployment containers | ||
| $ch = \curl_init(); |
There was a problem hiding this comment.
Just an idea, we have a CURL client in the e2e tests - maybe we can abastract it for this. We are doing alot of duplicate curl stuff all over the place.
There was a problem hiding this comment.
Yes we need to since there are a couple of places where we're making these calls. We should probably move the Client class to a different namespace for this.
What does this PR do?
In response to #2641
I've added a new worker called
buildsand started migrating the API calls from thefunctionscontroller to thebuildsworker.Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
#2641
#2673
Have you read the Contributing Guidelines on issues?
(Write your answer here.)