Functions Refactor #2641
Merged
Functions Refactor #2641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
eldadfux
reviewed
Jan 24, 2022
Closed
Member
lohanidamodar
left a comment
There was a problem hiding this comment.
Another round of brief review
| volumes: | ||
| - /var/run/docker.sock:/var/run/docker.sock | ||
| - appwrite-functions:/storage/functions:rw | ||
| - /tmp:/tmp:rw |
Member
There was a problem hiding this comment.
Yes, but we have a future task for refactoring all the functions mounts names.
Feat cleanup executor
…e into feat-cleanup-collections
Feat cleanup collections
…e into feat-add-deletes-worker
Co-authored-by: Matej Bačo <matejbacocom@gmail.com>
Co-authored-by: Matej Bačo <matejbacocom@gmail.com>
feat: add missing error codes
…e into feat-functions-refactor
…e into feat-functions-refactor
feat: realtime on deployments
TorstenDittmann
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is for the upcoming functions refactor introducing the new execution model to allow for significantly faster execution of functions and syncronous executions.
Test Plan
New tests have been written for syncronous execution and current tests have been updated for the new model.
Have you read the Contributing Guidelines on issues?
Yes