Ensures dev mode surfaces skaffold related errors properly#447
Merged
Ensures dev mode surfaces skaffold related errors properly#447
Conversation
mangas
approved these changes
Apr 7, 2021
ezodude
pushed a commit
that referenced
this pull request
Apr 14, 2021
ezodude
pushed a commit
that referenced
this pull request
Apr 16, 2021
marcinc
added a commit
that referenced
this pull request
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #440
Resolves #446
This PR adds elements missed in #440. Errors around presence of skaffold.yaml manifest are handled and surfaced in the UI.