Skip to content

[SSM-0001] Public API redesign#65

Merged
kukushechkin merged 15 commits intoapple:mainfrom
kukushechkin:swift-metrics-extras-1.0-proposal
Dec 3, 2025
Merged

[SSM-0001] Public API redesign#65
kukushechkin merged 15 commits intoapple:mainfrom
kukushechkin:swift-metrics-extras-1.0-proposal

Conversation

@kukushechkin
Copy link
Copy Markdown
Contributor

@kukushechkin kukushechkin commented Nov 24, 2025

Public API proposal doc and implementation.

Motivation:

As part of the 1.0 release we would like to revise the public API to simplify adoption and maintenance:

  • Reduce public API to a minimum to make it easier to support more platforms and metrics gathering strategies.
  • Decouple swift-metrics-extras public interface from the global MetricsSystem.
  • Add compatibility with swift-service-lifecycle

Modifications:

"SSM-0001: swift-metrics-extras revised public API to support 1.0 roadmap" proposal doc added

Result:

A proposal doc added.

@kukushechkin kukushechkin added the 🆕 semver/minor Adds new public API. label Nov 24, 2025
Copy link
Copy Markdown
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the draft implementation into a separate PR, so that this one only has the proposal. It seems some of the docs haven't been fully updated to match the proposal and we don't want the implementation to distract the review of the proposal.

Comment thread Sources/ServiceIntegrationExample/app.swift Outdated
Comment thread Sources/ServiceIntegrationExample/app.swift Outdated
Comment thread Sources/ServiceIntegrationExample/app.swift Outdated
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
Comment thread Sources/SystemMetrics/Docs.docc/index.md Outdated
@kukushechkin kukushechkin force-pushed the swift-metrics-extras-1.0-proposal branch from 9a90926 to d094c5a Compare November 24, 2025 14:59
@kukushechkin kukushechkin added semver/none No version bump required. and removed 🆕 semver/minor Adds new public API. labels Nov 24, 2025
Co-authored-by: Honza Dvorsky <honza@apple.com>
Copy link
Copy Markdown
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big +1 on the overall proposal, added a few suggestions.

Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
ktoso
ktoso previously requested changes Nov 26, 2025
Comment thread Sources/SystemMetrics/Docs.docc/Proposals/SSM-0001.md Outdated
@ktoso ktoso self-requested a review November 26, 2025 12:40
@kukushechkin kukushechkin enabled auto-merge (squash) December 3, 2025 17:33
@kukushechkin kukushechkin dismissed ktoso’s stale review December 3, 2025 17:46

The change was applied in a different PR.

@kukushechkin kukushechkin merged commit 6867490 into apple:main Dec 3, 2025
28 checks passed
@kukushechkin kukushechkin deleted the swift-metrics-extras-1.0-proposal branch December 4, 2025 10:13
@kukushechkin kukushechkin added this to the 1.0.0 milestone Dec 4, 2025
czechboy0 added a commit that referenced this pull request Dec 9, 2025
Implementation draft the SSM-0001 proposal the
#65

---------

Co-authored-by: Honza Dvorsky <honza@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants