[SSM-0001] Public API redesign#65
Merged
kukushechkin merged 15 commits intoapple:mainfrom Dec 3, 2025
Merged
Conversation
czechboy0
reviewed
Nov 24, 2025
Contributor
czechboy0
left a comment
There was a problem hiding this comment.
Please move the draft implementation into a separate PR, so that this one only has the proposal. It seems some of the docs haven't been fully updated to match the proposal and we don't want the implementation to distract the review of the proposal.
9a90926 to
d094c5a
Compare
Co-authored-by: Honza Dvorsky <honza@apple.com>
czechboy0
reviewed
Nov 24, 2025
Contributor
czechboy0
left a comment
There was a problem hiding this comment.
A big +1 on the overall proposal, added a few suggestions.
czechboy0
reviewed
Nov 25, 2025
Co-authored-by: Honza Dvorsky <honza@apple.com>
ktoso
previously requested changes
Nov 26, 2025
czechboy0
approved these changes
Dec 3, 2025
czechboy0
approved these changes
Dec 3, 2025
The change was applied in a different PR.
czechboy0
added a commit
that referenced
this pull request
Dec 9, 2025
Implementation draft the SSM-0001 proposal the #65 --------- Co-authored-by: Honza Dvorsky <honza@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API proposal doc and implementation.
Motivation:
As part of the 1.0 release we would like to revise the public API to simplify adoption and maintenance:
swift-metrics-extraspublic interface from the globalMetricsSystem.swift-service-lifecycleModifications:
"SSM-0001:
swift-metrics-extrasrevised public API to support 1.0 roadmap" proposal doc addedResult:
A proposal doc added.