Skip to content

Move gyb files to codegen#1136

Merged
kimdv merged 1 commit intoswiftlang:mainfrom
kimdv:kimdv/move-gyb-files-to-codegen
Dec 16, 2022
Merged

Move gyb files to codegen#1136
kimdv merged 1 commit intoswiftlang:mainfrom
kimdv:kimdv/move-gyb-files-to-codegen

Conversation

@kimdv
Copy link
Copy Markdown
Contributor

@kimdv kimdv commented Dec 12, 2022 •
edited
Loading

@kimdv kimdv requested a review from ahoppen as a code owner December 12, 2022 07:57
@kimdv kimdv force-pushed the kimdv/move-gyb-files-to-codegen branch 5 times, most recently from 4f1eb2a to ca10674 Compare December 14, 2022 15:25
@kimdv
Copy link
Copy Markdown
Contributor Author

kimdv commented Dec 14, 2022

@swift-ci please test

ahoppen
ahoppen approved these changes Dec 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. gyb is dying ☠️

@kimdv kimdv force-pushed the kimdv/move-gyb-files-to-codegen branch 2 times, most recently from 947e5ba to ad3ddf3 Compare December 15, 2022 20:26
This was referenced Dec 15, 2022
Merged
Merged
@kimdv
Copy link
Copy Markdown
Contributor Author

kimdv commented Dec 16, 2022

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/move-gyb-files-to-codegen branch from ad3ddf3 to b386e40 Compare December 16, 2022 06:33
@kimdv
Copy link
Copy Markdown
Contributor Author

kimdv commented Dec 16, 2022

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/move-gyb-files-to-codegen branch 2 times, most recently from 4400ab4 to 5948de5 Compare December 16, 2022 07:37
@kimdv kimdv requested a review from ahoppen December 16, 2022 07:37
@kimdv
Copy link
Copy Markdown
Contributor Author

kimdv commented Dec 16, 2022

@ahoppen will you review again?

kimdv
kimdv commented Dec 16, 2022
View reviewed changes
kimdv
kimdv commented Dec 16, 2022
View reviewed changes
@kimdv kimdv force-pushed the kimdv/move-gyb-files-to-codegen branch from 5948de5 to fcf6619 Compare December 16, 2022 07:43
@kimdv
Copy link
Copy Markdown
Contributor Author

kimdv commented Dec 16, 2022

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/move-gyb-files-to-codegen branch from fcf6619 to 7dc8c44 Compare December 16, 2022 08:30
@kimdv
Copy link
Copy Markdown
Contributor Author

kimdv commented Dec 16, 2022

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/move-gyb-files-to-codegen branch from 7dc8c44 to fbc1903 Compare December 16, 2022 08:44
@kimdv
Copy link
Copy Markdown
Contributor Author

kimdv commented Dec 16, 2022

@swift-ci please test

@kimdv kimdv merged commit 77aad96 into swiftlang:main Dec 16, 2022
@kimdv kimdv deleted the kimdv/move-gyb-files-to-codegen branch December 16, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kimdv @ahoppen