Move swiftsyntax/Misc gyb to syntax generator#1128
Merged
kimdv merged 1 commit intoswiftlang:mainfrom Dec 13, 2022
Merged
Conversation
f35abdc to
1513a85
Compare
Contributor
Author
|
@swift-ci please test |
kimdv
commented
Dec 11, 2022
1513a85 to
51637d1
Compare
ahoppen
reviewed
Dec 12, 2022
| .executable(name: "generate-swiftbasicformat", targets: ["generate-swiftbasicformat"]), | ||
| .executable(name: "generate-swiftideutils", targets: ["generate-swiftideutils"]), | ||
| .executable(name: "generate-swiftparser", targets: ["generate-swiftparser"]), | ||
| .executable(name: "generate-swiftsyntax", targets: ["generate-swiftsyntax"]), |
Member
There was a problem hiding this comment.
Not part of this PR but what do you think about having a single executable and adding an option that allows filtering of the files that should be generated?
Contributor
Author
There was a problem hiding this comment.
It sounds like a good idea, as this not scales that well 😅
I will come with a suggestion when this is merged
b75f780 to
881fd3e
Compare
Contributor
Author
|
@swift-ci please test |
881fd3e to
fa04041
Compare
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.