-
Notifications
You must be signed in to change notification settings - Fork 60
Comparing changes
Open a pull request
base repository: apple/swift-openapi-runtime
base: 1.10.1
head repository: apple/swift-openapi-runtime
compare: 1.11.0
- 10 commits
- 37 files changed
- 3 contributors
Commits on Feb 25, 2026
-
Use lock from NIO instead of NSLock (#172)
Part of apple/swift-openapi-generator#868 Remove usages of `NSLock` and vendor the lock from swift-nio instead.
Configuration menu - View commit details
-
Copy full SHA for 93e074e - Browse repository at this point
Copy the full SHA 93e074eView commit details -
Remove
localizedDescription(#173)Part of apple/swift-openapi-generator#868 Refactors `error.localizedDescription` to `"\(error)"` to prevent linking Foundation. This will change the error strings as can be seen in the tests. Alternatively, we would split the implementation by a trait `FullFoundationSupport`. Where that would use `localizedDescription`
Configuration menu - View commit details
-
Copy full SHA for 7d9cb54 - Browse repository at this point
Copy the full SHA 7d9cb54View commit details
Commits on Feb 26, 2026
-
Remove localized compares (#174)
Part of apple/swift-openapi-generator#868 Removes usages of localized compares from Foundation and just uses Swift string comparisons. The logic is covered by the following tests: ``` Test_URICodingRoundtrip.testRoundtrip Test_URISerializer.testSerializing Test_ClientConverterExtensions.test_setOptionalRequestBodyAsURLEncodedForm_codable Test_ClientConverterExtensions.test_setRequiredRequestBodyAsURLEncodedForm_codable ```
Configuration menu - View commit details
-
Copy full SHA for d34f76e - Browse repository at this point
Copy the full SHA d34f76eView commit details -
Remove
trimmingCharacters(in:)(#175)Part of apple/swift-openapi-generator#868 Removes usages of `trimmingCharacters(in:)` and replaced by simple Swift implementation. I added some tests that verify the behaviour against Foundation. --------- Co-authored-by: Honza Dvorsky <honza@apple.com>
Configuration menu - View commit details
-
Copy full SHA for 1ddb3ec - Browse repository at this point
Copy the full SHA 1ddb3ecView commit details
Commits on Mar 2, 2026
-
Replace Foundation
replacingOccurrences(of:with:)and percent encod……ing (#176) Part of apple/swift-openapi-generator#868 Introduces a Swift impl of `replacingOccurrences(of:with:)`, `addingPercentEncoding` and `removingPercentEncoding`. The percent encoding were inspired by impl in `swift-foundation`: https://github.com/swiftlang/swift-foundation/blob/aee1d337039b5b2a1f0c3b7f83baa950dac3a84e/Sources/FoundationEssentials/URL/URLParser.swift I also added tests to verify behaviour with Foundation.
Configuration menu - View commit details
-
Copy full SHA for 949dfed - Browse repository at this point
Copy the full SHA 949dfedView commit details -
Replace
String(format:)forDoubleto String conversions (#178)Part of apple/swift-openapi-generator#868 Introduces a Swift-only impl of `String(format:)` that is only used in `QualityValue.rawValue`. --------- Co-authored-by: Honza Dvorsky <honza@apple.com>
Configuration menu - View commit details
-
Copy full SHA for 6d55957 - Browse repository at this point
Copy the full SHA 6d55957View commit details -
Introduce
FullFoundationtrait (#177)Part of apple/swift-openapi-generator#868 This PR introduces a new default trait `FullFoundationSupport`. If users remove this trait it does two things: 1. On non-darwin platforms it replaces the use of `ISO8601DateFormatter` with the new Foundation APIs. 2. Disables support for `NSNull` and `NSNumber` in `OpenAPIValue`. If non-darwin platforms disable this trait, its technically source breaking if they rely on the initializer of `ISO8601DateTranscoder`, because it relies on the `ISO8601DateFormatter.Options` object. I am not sure how we would get around that. But again, it requires users to explicitly remove the trait, and thereby want to opt in to only relying on FoundationEssentials. So imo its acceptable. I am not sure about CI. We really should be testing with and without the trait, but I could not find other examples that use the swift-nio jobs to do this. But if you could point me in the right direction, I can add that as well. From what I understand from @FranzBusch, we also only have 1 chance of adding default traits. Are there any other traits we should think about introducing? --------- Co-authored-by: Honza Dvorsky <honza@apple.com>
Configuration menu - View commit details
-
Copy full SHA for 80f395b - Browse repository at this point
Copy the full SHA 80f395bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fb0779 - Browse repository at this point
Copy the full SHA 8fb0779View commit details
Commits on Mar 3, 2026
-
Configuration menu - View commit details
-
Copy full SHA for b8451c6 - Browse repository at this point
Copy the full SHA b8451c6View commit details -
Make sure we can import CoreFoundation (#181)
Fixes Windows build by making sure we can import CoreFoundation
Configuration menu - View commit details
-
Copy full SHA for f039fa6 - Browse repository at this point
Copy the full SHA f039fa6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.10.1...1.11.0