Skip to content

Remove use of Foundation appending and add last FoundationEssentials imports#180

Merged
czechboy0 merged 3 commits intoapple:mainfrom
madsodgaard:appending
Mar 2, 2026
Merged

Remove use of Foundation appending and add last FoundationEssentials imports#180
czechboy0 merged 3 commits intoapple:mainfrom
madsodgaard:appending

Conversation

@madsodgaard
Copy link
Copy Markdown
Contributor

@madsodgaard madsodgaard commented Mar 2, 2026 •
edited
Loading

I missed this one, but we were also calling appending from Foundation. Just changed to a normal string concatenation.

Also, this adds the last remaining import FoundationEssentials. OpenAPIRuntime now only links against FoundationEssentials 🎉

| LDD output:
| 	linux-vdso.so.1 (0x0000ffff883a5000)
| 	libswiftCore.so => /usr/lib/swift/linux/libswiftCore.so (0x0000ffff87a00000)
| 	libswift_Concurrency.so => /usr/lib/swift/linux/libswift_Concurrency.so (0x0000ffff88160000)
| 	libswift_StringProcessing.so => /usr/lib/swift/linux/libswift_StringProcessing.so (0x0000ffff880a0000)
| 	libswift_RegexParser.so => /usr/lib/swift/linux/libswift_RegexParser.so (0x0000ffff878e0000)
| 	libswiftSynchronization.so => /usr/lib/swift/linux/libswiftSynchronization.so (0x0000ffff878b0000)
| 	libswiftGlibc.so => /usr/lib/swift/linux/libswiftGlibc.so (0x0000ffff87880000)
| 	libFoundationEssentials.so => /usr/lib/swift/linux/libFoundationEssentials.so (0x0000ffff87200000)
| 	libm.so.6 => /lib/aarch64-linux-gnu/libm.so.6 (0x0000ffff87150000)
| 	libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000ffff86f90000)
| 	/lib/ld-linux-aarch64.so.1 (0x0000ffff88368000)
| 	libstdc++.so.6 => /lib/aarch64-linux-gnu/libstdc++.so.6 (0x0000ffff86c00000)
| 	libgcc_s.so.1 => /lib/aarch64-linux-gnu/libgcc_s.so.1 (0x0000ffff87840000)
| 	libdispatch.so => /usr/lib/swift/linux/libdispatch.so (0x0000ffff86f10000)
| 	libswift_Builtin_float.so => /usr/lib/swift/linux/libswift_Builtin_float.so (0x0000ffff86ee0000)
| 	libBlocksRuntime.so => /usr/lib/swift/linux/libBlocksRuntime.so (0x0000ffff86eb0000)
| Success: Binary is not linked against libFoundation.so - linkage test passed.

@madsodgaard madsodgaard changed the title Add Swift impl of appending Add Swift impl of appending and last FoundationEssentials import Mar 2, 2026
@madsodgaard madsodgaard changed the title Add Swift impl of appending and last FoundationEssentials import Remove use of Foundation appending and add last FoundationEssentials imports Mar 2, 2026
czechboy0
czechboy0 approved these changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @madsodgaard 🎉

@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Mar 2, 2026
@czechboy0 czechboy0 enabled auto-merge (squash) March 2, 2026 20:47
@czechboy0 czechboy0 merged commit 8fb0779 into apple:main Mar 2, 2026
38 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czechboy0 czechboy0 czechboy0 approved these changes

Assignees

No one assigned

Labels

🔨 semver/patch No public API change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@madsodgaard @czechboy0