Add symlinkat, renameatx_np, and unlinkat system call wrappers#3505
Merged
glbrntt merged 3 commits intoapple:mainfrom Feb 9, 2026
Merged
Add symlinkat, renameatx_np, and unlinkat system call wrappers#3505glbrntt merged 3 commits intoapple:mainfrom
symlinkat, renameatx_np, and unlinkat system call wrappers#3505glbrntt merged 3 commits intoapple:mainfrom
Conversation
glbrntt
approved these changes
Feb 9, 2026
Contributor
glbrntt
left a comment
There was a problem hiding this comment.
LGTM, thanks @stepan-ulyanin!
glbrntt
pushed a commit
that referenced
this pull request
Mar 2, 2026
…to the `_NIOFileSystem` module (#3524) Ports the added system calls from `NIOFS` (from #3505) to `_NIOFileSystem`: > Adds three new system call wrappers for the `symlinkat`, `renameatx_np`, and `unlinkat` system calls. ### Motivation: `_NIOFileSystem` module is around for backward compatibility - hence, we are porting the new feature to it. ### Modifications: Exactly same as in #3505 but applied to the `_NIOFileSystem`: > Related to #3403 and #3470. This PR adds syscall wrappers needed to atomically overwrite existing files or symlinks at the destination during copy operations. On Linux, atomic overwrites require a "copy to temp file, then rename" strategy. We use the `*at` family of syscalls (which operate relative to directory file descriptors) to avoid TOCTOU race conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three new system call wrappers for the
symlinkat,renameatx_np, andunlinkatsystem calls.Motivation:
Related to #3403 and #3470. This PR adds syscall wrappers needed to atomically overwrite existing files or symlinks at the destination during copy operations. On Linux, atomic overwrites require a "copy to temp file, then rename" strategy. We use the
*atfamily of syscalls (which operate relative to directory file descriptors) to avoid TOCTOU race conditions.Modifications:
symlinkat,renameatx_np, andunlinkatsystem calls.FileSystemErrorforsymlinkandunlinkto take in the system call name to allow for the*atnames to be passed.