Merged
Conversation
kukushechkin
pushed a commit
to apple/swift-distributed-tracing
that referenced
this pull request
Feb 11, 2026
#210) Ports changes to `Lock` from `swift-nio` and `swift-log` to `swift-distributed-tracing`. ### Motivation: The copy-paste of `Lock` in `swift-distributed-tracing` should be updated with changes from swift-nio. ### Modifications: - This is a near straight copy of the changes brought from swift-nio to swift-log in apple/swift-log#408. ### Result: `Lock` implementation will have the same or nearly the same implementation as swift-nio (assuming apple/swift-nio#3494 merges). `Lock` will also have the same implementation as swift-log, once apple/swift-log#408 merges.
kukushechkin
pushed a commit
to apple/swift-log
that referenced
this pull request
Feb 12, 2026
…408) Ports changes to `Lock` from swift-nio to swift-log. ### Motivation: The copy-paste of `Lock` in swift-log should be updated with changes from swift-nio. ### Modifications: - Rolls back changed [made previously for FreeBSD](https://github.com/apple/swift-log/pull/387/changes#diff-7b1bd45403dd1a7418287bd60682bf05ba2e4bf75dca1c0ca55a86d0477c9af5L73) in favor of a consolidated implementation in swift-nio that will be in place once apple/swift-nio#3494 merges. @kkebo Please confirm this works. After both of our PR's merge, swift-log and swift-nio will have the same implementation as far as FreeBSD is concerned. - Brought the following recent changes from swift-nio over to swift-log: - apple/swift-nio#3482 - apple/swift-nio#3480 - apple/swift-nio#3483 - Removed stale `// SRWLOCK does not need to be free'd` comment. ### Result: `Lock` implementation will have the same implementation as swift-nio (assuming apple/swift-nio#3494 merges).
Contributor
Author
|
I rebased and fixed the newly added NIOThreadPoolWorkAvailable.swift file. |
Lukasa
approved these changes
Mar 18, 2026
Contributor
Lukasa
left a comment
There was a problem hiding this comment.
Thanks, this looks like a good cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for FreeBSD to the
CNIOSHA1target and theNIOConcurrencyHelperstarget.Motivation:
This PR is partial because the
NIOCoretarget still can't be built, and the existing PR #3398 includes almost the same changes too.However, #3398 is a little bit old. Besides, the source code in
NIOConcurrencyHelpersis used in other repositories now, for example:So I think it's important to fix
NIOConcurrencyHelpersfirst, even if the entire swift-nio is yet to be fixed.Modifications:
swift build --target NIOConcurrencyHelperswork on FreeBSDswift build --target CNIOSHA1work on FreeBSDResult:
The following commands finished successfully.
Environment: