Conversation
58c5d4b to
58401c5
Compare
58401c5 to
ffbfeae
Compare
fabianfett
commented
Sep 19, 2025
Comment on lines
+90
to
+93
| xcode_16_4_setup_command: | ||
| type: string | ||
| description: "The command(s) to be executed before all other work." | ||
| default: "" |
Member
Author
There was a problem hiding this comment.
this had a weird position that I fixed.
fabianfett
commented
Sep 19, 2025
| xcode_16_4_test_arguments_override="${MATRIX_MACOS_16_4_TEST_ARGUMENTS_OVERRIDE:=""}" | ||
| xcode_16_4_setup_command="${MATRIX_MACOS_16_4_SETUP_COMMAND:=""}" | ||
| xcode_26_0_enabled="${MATRIX_MACOS_12_30ENABLED:=true}" | ||
| xcode_26_0_enabled="${MATRIX_MACOS_26_0_ENABLED:=true}" |
Contributor
There was a problem hiding this comment.
Nope, that's a bug, thank you
Member
Author
|
The good CI run: |
This reverts commit ffbfeae.
rnro
approved these changes
Sep 19, 2025
Contributor
rnro
left a comment
There was a problem hiding this comment.
This looks great, thanks for the thorough changes @fabianfett
Lukasa
approved these changes
Sep 19, 2025
Contributor
|
Admin merge over the broken checks. |
euanh
added a commit
to euanh/swift-container-plugin
that referenced
this pull request
Sep 22, 2025
Motivation ---------- Swift NIO's unit test matrix job has been [updated for Swift 6.2](apple/swift-nio#3374), so additional override flags must be defined. Modifications ------------- Define `linux_6.2_arguments_override` for pull requests and the scheduled build on main. Result ------ Tests with Swift 6.2 will pass. Test Plan --------- Existing tests pass again.
euanh
added a commit
to apple/swift-container-plugin
that referenced
this pull request
Sep 22, 2025
Motivation ---------- Swift NIO's unit test matrix job has been [updated for Swift 6.2](apple/swift-nio#3374), so additional override flags must be defined. Modifications ------------- Define `linux_6_2_arguments_override` for pull requests and the scheduled build on main. Result ------ Tests with Swift 6.2 will pass. Test Plan --------- Existing tests pass again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces: #3373