NIOThread: remove the detached threads functionality#3304
Merged
weissi merged 1 commit intoapple:mainfrom Jul 15, 2025
Merged
Conversation
Lukasa
reviewed
Jul 15, 2025
| internal init(handle: ThreadOpsSystem.ThreadHandle, isDetachedThread: Bool, desiredName: String?) { | ||
| self.handle = NIOLockedValueBox(isDetachedThread ? nil : handle) | ||
| internal init(handle: ThreadOpsSystem.ThreadHandle, desiredName: String?) { | ||
| self.handle = NIOLockedValueBox(handle) |
Contributor
There was a problem hiding this comment.
This is being optional-promoted, you can remove the optional on the type definition.
Member
Author
There was a problem hiding this comment.
Alas when we join() we need to set it to nil to not hold onto the then-deallocated pthread_t.
Lukasa
approved these changes
Jul 15, 2025
zaneenders
pushed a commit
to zaneenders/swift-nio
that referenced
this pull request
Jul 23, 2025
### Motivation: Structured Concurrency is helpful but so far, MTELG was very difficult to use with it mostly because Swift is still missing `async` in `defer`s. This builds on - apple#3297 - apple#3302 - apple#3304 ### Modifications: - Add MTELG.withELG { ... } ### Result: MTELG + SC = <3
zaneenders
pushed a commit
to zaneenders/swift-nio
that referenced
this pull request
Jul 23, 2025
### Motivation: Detached threads are a bad idea, their lifetime becomes random and NIO doesn't need this functionality (except for in some tests that are easily refactored) ### Modifications: - Refactor tests to not use detached threads - Remove detached threads functionality ### Result: - Cleaner, less complex and more correct code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Detached threads are a bad idea, their lifetime becomes random and NIO doesn't need this functionality (except for in some tests that are easily refactored)
Modifications:
Result: