Conversation
|
@czechboy0 I pulled down your branch and it compiles fine to wasm. It looks like it just needs rebased or merged with the latest Any chance you might be able to resolve the conflicts. Or would you be ok if I resolved them for you and rebased your branch on the latest main? |
scottmarchant
left a comment
There was a problem hiding this comment.
This is great! I pulled the changes down locally and was able to compile to wasm.
|
@czechboy0 Just wanted to check one last time before I try to push to your branch with a rebase to update on the latest main. Is updating with the latest Please let me know how I can help 😀 |
|
Hi @czechboy0 I resolved the merge conflicts for this locally. If you give me ( |
|
Hi @scottmarchant - thank you, please open a new PR and we can close this one |
… pick czechboy0's initial wasm support provided in apple#183 with merge conflicts resolved.
… pick czechboy0's initial wasm support provided in apple#183 with merge conflicts resolved.
|
@czechboy0 New PR with resolved conflicts is available now: |
|
@FranzBusch Per the conversation above, I believe this PR can be closed now that #190 is available with the resolved conflicts. |
|
Obsoleted by #190 |
… pick czechboy0's initial wasm support provided in apple#183 with merge conflicts resolved. This also contains the latest Lock implementations from NIO, duplicated first in swift-log: apple/swift-log#398
… pick czechboy0's initial wasm support provided in apple#183 with merge conflicts resolved. This also contains the latest Lock implementations from NIO, duplicated first in swift-log: apple/swift-log#398
… WebAssembly (#190) ### Motivation: As part of expanding platform and CI coverage of Swift Configuration, Swift Metrics should also build to Wasm using the [Swift SDK for WebAssembly](https://www.swift.org/documentation/articles/wasm-getting-started.html). ### Modifications: Brought over locking changes from Swift Log to support Wasm. Conditionally elided some APIs that require Dispatch when Dispatch isn't available. ### Result: The package now builds against the Wasm SDK, both normal and the test targets. ### Important This PR is a cherry pick of #183 created by @czechboy0. It has been modified to resolve conflicts and is rebased on the latest `main`.
Motivation:
As part of expanding platform and CI coverage of Swift Configuration, Swift Metrics should also build on Wasm.
Modifications:
Result:
The package now builds against the Wasm SDK, both normal and the test targets.