ci: Switch to shared GitHub actions for soundness checks#5
Merged
euanh merged 1 commit intoapple:mainfrom Sep 30, 2024
Merged
Conversation
a33be54 to
16393da
Compare
16393da to
1550dce
Compare
euanh
pushed a commit
that referenced
this pull request
Apr 16, 2025
…vice to run locally (#97) ### Motivation scripts/soundness.sh was deleted in #5 which moved CI to GitHub Actions. resolves #96 ### Modifications Remove the instruction to run `scripts/soundness.sh` from `CONTRIBUTING.md`. ### Result Documentation no longer refers to nonexistent scripts. ### Test Plan No functional change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The server-side Swift projects are starting to adopt CI based on GitHub Actions, using shared scripts. GitHub Actions can do everything we need for CI, so we should adopt it as well.
Modifications
Use the shared GitHub actions (currently hosted in
swift-nio) to run the soundness checks for Pull Requests.Result
Soundness checks will be run for future Pull Requests.
Test Plan
Ran the checks locally using
act pull_request.