[NFC] Improving edit distance string extension#446
Merged
natecook1000 merged 2 commits intoapple:mainfrom Jun 5, 2022
Merged
Conversation
Contributor
Author
|
@swift-ci Please test |
f600e11 to
2c913fe
Compare
2c913fe to
b959d6d
Compare
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
Member
|
@swift-ci Please test |
leuski
pushed a commit
to leuski/swift-argument-parser
that referenced
this pull request
Jun 17, 2022
* 'main' of github.com:apple/swift-argument-parser: (114 commits) Fix `AsyncParseableCommand` hierarchy (apple#436) Add experimental manual page generation (apple#332) Improving edit distance string extension (apple#446) List valid options in error messages for enum array argument (apple#445) Remove LinuxMain.swift (apple#367) Hide hidden subcommands from completions (apple#443) Update changelog for 1.1.2 release (apple#441) Fix error message for @option array without values (apple#435) Fix Repeat's endless printing (apple#437) build: statically link ArgumentParserToolInfo always (apple#424) Update changelog for the 1.1.1 release (apple#428) build: complete the changes from apple#423 (apple#425) Remove platform requirement from Package.swift (apple#427) build: repair the build after apple#404 (apple#423) Fix broken links/incorrect variance calculation (apple#422) Update changelog for the 1.1.0 release (apple#421) Update documentation (apple#420) Make `@OptionGroup(visibility:)` a public API (apple#419) Support an `async` entry point for commands (apple#404) Fix a typo and template links (apple#418) ...
rauhul
added a commit
that referenced
this pull request
Aug 26, 2022
- Start of a fix for issue 446. After an initial read through the code it feels like there more @argument initializers than needed and this logic can probably be reudced and simplified. - Fixes isOptional derivision for non-Optional @arguments with default values, however the simple solution doesn't work properly for Optional @arguments without a non-nil default value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving implementation of edit distance string extension by:
n + 1instead of anm x nmatrix.Been playing around with ways to improve it more in https://github.com/LucianoPAlmeida/strings
Benchmarks
Code:
Checklist