Tls plugin #343
Merged
Tls plugin #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for https in backup.
…disable checking.
etschannen
reviewed
May 9, 2018
| { TLSOptions::OPT_TLS_VERIFY_PEERS, TLS_VERIFY_PEERS_FLAG, SO_REQ_SEP }, \ | ||
| { TLSOptions::OPT_TLS_PASSWORD, TLS_PASSWORD_FLAG, SO_REQ_SEP }, \ | ||
| { TLSOptions::OPT_TLS_CA_FILE, TLS_CA_FILE_FLAG, SO_REQ_SEP }, | ||
|
|
Contributor
There was a problem hiding this comment.
The white space seems wrong
| description="Set the ca bundle" /> | ||
| <Option name="TLS_ca_path" code="53" | ||
| paramType="String" paramDescription="file path" | ||
| description="Set the file from which to load the certificate authority bundle" /> |
Contributor
There was a problem hiding this comment.
Inconsistent indenting
fdbrpc/TLSConnection.h
Outdated
|
|
||
| TLSOptions() : certs_set(false), key_set(false), verify_peers_set(false) {} | ||
| enum { OPT_TLS = 100000, OPT_TLS_PLUGIN, OPT_TLS_CERTIFICATES, OPT_TLS_KEY, OPT_TLS_VERIFY_PEERS, OPT_TLS_CA_FILE }; | ||
| enum POLICY_TYPE { POLICY_VERIFY_PEERS = 1, POLICY_NO_VERIFY_PEERS }; |
Contributor
There was a problem hiding this comment.
s/POLICY_TYPE/PolicyType/, and preferably enum class.
fdbrpc/TLSConnection.h
Outdated
| void register_network(); | ||
|
|
||
| Reference<ITLSPolicy> get_policy(); | ||
| Reference<ITLSPolicy> get_policy(enum POLICY_TYPE type); |
Contributor
There was a problem hiding this comment.
enum POLICY_TYPE -> PolicyType.
Remove redundant FDBLibTLS/ITLSPlugin.h.
sfc-gh-jfu
pushed a commit
to sfc-gh-jfu/foundationdb
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate new tls plugin and add https support for backup