Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

Off by one error in ipp_finishings_vendor#5695

Merged
michaelrsweet merged 1 commit into
apple:masterfrom
IslandCow:vendor_finishings
Dec 4, 2019
Merged

Off by one error in ipp_finishings_vendor#5695
michaelrsweet merged 1 commit into
apple:masterfrom
IslandCow:vendor_finishings

Conversation

@IslandCow

Copy link
Copy Markdown

When enumvalue is 101 and attrname is "finsishings-supported"
we were getting the memory after ipp_finishings_vendor
in the ipp_job_collation_types array.

When enumvalue is 101 and attrname is "finsishings-supported"
we were getting the memory after ipp_finishings_vendor
in the ipp_job_collation_types array.
@michaelrsweet

Copy link
Copy Markdown
Contributor

I don't see how this happens with value 101. 0x40000066 maybe, but not 101.

Anyways, will take the fix.

@michaelrsweet michaelrsweet self-assigned this Dec 4, 2019
@michaelrsweet michaelrsweet added this to the CUPS 2.3.x milestone Dec 4, 2019
@michaelrsweet michaelrsweet merged commit 0f98a48 into apple:master Dec 4, 2019
@IslandCow

Copy link
Copy Markdown
Author

Thanks for pulling. The problematic value is 0x40000065 because the length of the array is 0x65 or 101.

@IslandCow IslandCow deleted the vendor_finishings branch December 5, 2019 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants