This repository was archived by the owner on Mar 10, 2026. It is now read-only.
Prevent cert creation failure on leap day#5643
Closed
mattjohnsonpint wants to merge 1 commit into
Closed
Conversation
503b156 to
a92558a
Compare
Contributor
|
FWIW, I'm not aware of too many users of libcups on Windows to provide an IPP server, but I'll make sure to include this fix in the next patch update... |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
http_sspi_make_credentialsfunction incups/tls-sspi.chas a leap year bug.cups/cups/tls-sspi.c
Lines 1968 to 1973 in bc5060a
This will fail if the code is executed on Feb 29th of a leap year (of which 2020 is the next one), unless the
yearsbeing added also results inet.wYearbeing a leap year. In other words,2020-02-29+1 yearwould result in2021-02-29, which does not exist. In this case,CertCreateSelfSignCertificatewill fail.The attached PR checks for this condition, and adjusts such dates back one day to February 28th, which is a reasonable and common practice.
Please be sure this gets merged and highlighted in the release notes. Those that rely on this code path will want to have fully deployed such code well before leap day 2020. Thanks.