Skip to content

chore: run pre-commit autoupdate#890

Merged
KazuCocoa merged 1 commit intomasterfrom
update-precommit
Jul 8, 2023
Merged

chore: run pre-commit autoupdate#890
KazuCocoa merged 1 commit intomasterfrom
update-precommit

Conversation

@KazuCocoa
Copy link
Copy Markdown
Member

Ran pre-commit autoupdate. Pipfile.lock has the same version.

I wondered if we could sync the rev and Pipfile.lock, but probably no good way...?

@KazuCocoa KazuCocoa requested a review from mykola-mokhnach July 8, 2023 06:01
args: [ "." ]
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.961
rev: v1.4.1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to just use the most recent snapshot there instead of a fixed revision?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially wondered if the rev could be removed. Let me research further later.

I saw the rev was optional in a stack overflow but the official doc didn't address that.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like pre-commit autoupdate is the only thing we could do to update versions, so maybe the best way is run pre-commit autoupdate via CI task and commit it on it...?

Anyway, this pr has nothing we can do more

@KazuCocoa KazuCocoa merged commit 0cf35fc into master Jul 8, 2023
@KazuCocoa KazuCocoa deleted the update-precommit branch July 8, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants