refactor: Update types descriptions for mixin classes#677
Merged
mykola-mokhnach merged 5 commits intoappium:masterfrom Jan 14, 2022
Merged
refactor: Update types descriptions for mixin classes#677mykola-mokhnach merged 5 commits intoappium:masterfrom
mykola-mokhnach merged 5 commits intoappium:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The right way to describe types for mixin classes is to use protocols as suggested by Guido. This PR also simplifies the current implementation and adds more clarity to the module typing system in general.