chore: add deprecated mark for find_element_by*#657
Merged
KazuCocoa merged 1 commit intoappium:masterfrom Nov 24, 2021
Merged
Conversation
mykola-mokhnach
approved these changes
Nov 24, 2021
Contributor
mykola-mokhnach
left a comment
There was a problem hiding this comment.
It would also make sense to deprecate MobileBy and rename it to AppiumBy, like we did in java client. the reason for it that Appium does not just support mobile platforms and suhc locations don't make much sense for Desktop automation
Member
Author
|
I see. It makes sense > AppiumBy Let me add it and update deprecation messages to use it instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #645
It looks like we've recommended to use
find_element_by_*instead of vanillafine_element(xxx), so let's print deprecated message first (and for a while)