feat: Change base selenium client version to selenium 4#636
Merged
feat: Change base selenium client version to selenium 4#636
Conversation
* Bump 2.0.0.b1 * Update changelog for 2.0.0.b1 * remove w3c
* chore: add placeholder * move to extention way * revert pytest * add todo * call method_name instead of wrapper * remove types * rename a method * add examples * add types-python-dateutil as error message * add example more * tweak naming * Explicit Dict
* feat: add satellites in set_location * fix review
Updates the requirements on [tox](https://github.com/tox-dev/tox) to permit the latest version. - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/master/docs/changelog.rst) - [Commits](tox-dev/tox@3.23.0...3.24.0) --- updated-dependencies: - dependency-name: tox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [pylint](https://github.com/PyCQA/pylint) to permit the latest version. - [Release notes](https://github.com/PyCQA/pylint/releases) - [Changelog](https://github.com/PyCQA/pylint/blob/main/ChangeLog) - [Commits](pylint-dev/pylint@pylint-2.8.0...v2.10.2) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Member
Author
|
No, Python client still has https://github.com/SeleniumHQ/selenium/blob/db6d118967b648b71343c9c5183ccf6f6c4887af/py/selenium/webdriver/remote/webelement.py#L170 |
Member
Author
|
will clean up changelog. |
| from test.unit.helper.test_helper import appium_command, get_httpretty_request_body, ios_w3c_driver | ||
|
|
||
|
|
||
| class TestWebDriverLog(object): |
Contributor
There was a problem hiding this comment.
in Py3 it is not necessary to inherit classes from object anymore
Member
Author
There was a problem hiding this comment.
Yea. I followed other tests in this pr. Will create a follow-up PR to update tests.
|
|
||
| class TestWebDriverLog(object): | ||
| @httpretty.activate | ||
| def test_get_log_types(self): |
Contributor
There was a problem hiding this comment.
would it be possible to use pytest style and write test methods at the module level instead of putting them into a class?
mykola-mokhnach
approved these changes
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
forceMjsonwpworksstrict_ssloption inwebdriver.RemoteI'll address the above change in this release note, and will summarize this merge note so that next release note can show these changes