feat: add satellites in set_location#620
Merged
KazuCocoa merged 2 commits intoappium:masterfrom Jul 21, 2021
Merged
Conversation
| longitude: String or numeric value between -180.0 and 180.0 | ||
| altitude: String or numeric value (Android real device only) | ||
| speed: String or numeric value larger than 0.0 (Android real devices only) | ||
| satellites: String or numeric value since Appium 1.22.0 |
Contributor
There was a problem hiding this comment.
We could have a more precise documentation string here:
Count of active GPS satellites in range 1..12. Only works for Emulators.
| driver = android_w3c_driver() | ||
| httpretty.register_uri(httpretty.POST, appium_command('/session/1234567890/location')) | ||
| assert isinstance(driver.set_location(11.1, 22.2, 33.3, 23.2), WebDriver) | ||
| assert isinstance(driver.set_location(11.1, 22.2, 33.3, 23.2, 0), WebDriver) |
Contributor
There was a problem hiding this comment.
zero is not an acceptable value
mykola-mokhnach
approved these changes
Jul 21, 2021
KazuCocoa
added a commit
that referenced
this pull request
Aug 29, 2021
* feat: add satellites in set_location * fix review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.