Use JSON serialization for cachefrom option#793
Merged
apocas merged 1 commit intoapocas:masterfrom Mar 6, 2025
Merged
Conversation
b9b66ef to
dd15e14
Compare
Docker [ImageBuild](https://docs.docker.com/reference/api/engine/version/v1.48/#tag/Image/operation/ImageBuild) endpoint requires that the `cachefrom` option is a "JSON serialized array". This requirement seems to be an exception to the way arrays are consumed by the API (usually querystring serialized). This change is needed after apocas/docker-modem#181 that makes querystring serialized arrays the default. This commit adds an exception for this option on `Docker.buildImage`. Change-type: patch Closes: apocas#792
dd15e14 to
88597cc
Compare
pipex
added a commit
to balena-io-modules/balena-compose
that referenced
this pull request
Feb 24, 2025
A change the way options are serialized in docker-modem causes an issue with builds using the `cachefrom` option and library tests to fail. This change can be reverted if apocas/dockerode#793 is merged. Change-type: patch Relates-to: apocas/docker-modem#181 Relates-to: apocas/dockerode#792
pipex
added a commit
to balena-io-modules/balena-compose
that referenced
this pull request
Feb 25, 2025
A change the way options are serialized in docker-modem causes an issue with builds using the `cachefrom` option and library tests to fail. This change can be reverted if apocas/dockerode#793 is merged. Change-type: patch Relates-to: apocas/docker-modem#181 Relates-to: apocas/dockerode#792
Owner
|
Yeah Docker's API never was an example of consistency and sometimes these things happen :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker ImageBuild endpoint requires that the
cachefromoption is a "JSON serialized array". This requirement seems to be an exception to the way arrays are consumed by the API (usually querystring serialized).This change is needed after apocas/docker-modem#181 that makes querystring serialized arrays the default.
This commit adds an exception for this option on
Docker.buildImage.Change-type: patch
Closes: #792