ZOOKEEPER-2678: Discovery and Sync can take a very long time on large DBs (master) #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This also applies cleanly to the 3.5 line #157 is for the 3.4 line |
hanm
reviewed
Feb 9, 2017
| case Leader.NEWLEADER: // it will be NEWLEADER in v1.0 | ||
| case Leader.NEWLEADER: // Getting NEWLEADER here instead of in discovery | ||
| // means this is Zab 1.0 | ||
| // Create updatingEpoch file and remove it after current |
Contributor
There was a problem hiding this comment.
This comment does not apply here - my guess is it is a copy paste error from your branch-3.4 patch... can we get this comment removed?
Author
|
@hanm thanks for the reviews I removed the incorrect comment. |
asfgit
pushed a commit
that referenced
this pull request
Feb 16, 2017
… DBs (master) This is the master version of #157 Author: Robert (Bobby) Evans <evans@yahoo-inc.com> Reviewers: Flavio Junqueira <fpj@apache.org>, Edward Ribeiro <edward.ribeiro@gmail.com>, Abraham Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes #159 from revans2/ZOOKEEPER-2678-master and squashes the following commits: 69fbe19 [Robert (Bobby) Evans] ZOOKEEPER-2678: Addressed review comments a432642 [Robert (Bobby) Evans] ZOOKEEPER-2678: Improved test to verify snapshot times 742367e [Robert (Bobby) Evans] Addressed review comments f4c5b0e [Robert (Bobby) Evans] ZOOKEEPER-2678: Discovery and Sync can take a very long time on large DBs
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
… DBs (master) This is the master version of apache#157 Author: Robert (Bobby) Evans <evans@yahoo-inc.com> Reviewers: Flavio Junqueira <fpj@apache.org>, Edward Ribeiro <edward.ribeiro@gmail.com>, Abraham Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes apache#159 from revans2/ZOOKEEPER-2678-master and squashes the following commits: 69fbe19 [Robert (Bobby) Evans] ZOOKEEPER-2678: Addressed review comments a432642 [Robert (Bobby) Evans] ZOOKEEPER-2678: Improved test to verify snapshot times 742367e [Robert (Bobby) Evans] Addressed review comments f4c5b0e [Robert (Bobby) Evans] ZOOKEEPER-2678: Discovery and Sync can take a very long time on large DBs
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
… DBs (master) This is the master version of apache#157 Author: Robert (Bobby) Evans <evans@yahoo-inc.com> Reviewers: Flavio Junqueira <fpj@apache.org>, Edward Ribeiro <edward.ribeiro@gmail.com>, Abraham Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes apache#159 from revans2/ZOOKEEPER-2678-master and squashes the following commits: 69fbe19 [Robert (Bobby) Evans] ZOOKEEPER-2678: Addressed review comments a432642 [Robert (Bobby) Evans] ZOOKEEPER-2678: Improved test to verify snapshot times 742367e [Robert (Bobby) Evans] Addressed review comments f4c5b0e [Robert (Bobby) Evans] ZOOKEEPER-2678: Discovery and Sync can take a very long time on large DBs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the master version of #157