[ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api#4362
Merged
zjffdu merged 2 commits intoapache:masterfrom Apr 27, 2022
Merged
[ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api#4362zjffdu merged 2 commits intoapache:masterfrom
zjffdu merged 2 commits intoapache:masterfrom
Conversation
zjffdu
reviewed
Apr 19, 2022
...client-examples/src/main/java/org/apache/zeppelin/client/examples/ZeppelinClientExample.java
Show resolved
Hide resolved
Contributor
Author
|
😅 I just add a method in Zeppelin Client and do nothing else. The log of failed CI tasks is about Jupyter kernel. |
Contributor
This error is not related with your PR. It also happens in master |
Contributor
|
@huage1994 CI issue is fixed, please rebase your PR |
4bdba17 to
4ad9eb7
Compare
Contributor
Author
|
Thanks @zjffdu a lot. I have added test and rebased my PR. |
zjffdu
approved these changes
Apr 25, 2022
Contributor
|
CI is passed, will merge if no more comment |
3 tasks
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
May 2, 2022
…pache#4362) * [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api * add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently there's a cancelParagraph method in zeppelin client api, however, there's no cancelNote method.
PR is to add a cancelNote method in zeppelin client api.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: