[#715] fix(mr): The container does not exit because shuffleclient is not closed #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #882 +/- ##
============================================
- Coverage 58.60% 57.26% -1.34%
- Complexity 1580 2172 +592
============================================
Files 194 310 +116
Lines 10871 13898 +3027
Branches 956 1278 +322
============================================
+ Hits 6371 7959 +1588
- Misses 4126 5507 +1381
- Partials 374 432 +58 ☔ View full report in Codecov by Sentry. |
jerqi
reviewed
May 15, 2023
client-mr/src/main/java/org/apache/hadoop/mapred/RssMapOutputCollector.java
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM, thanks @zhaobing001 , good catch! merged to master. |
jerqi
approved these changes
May 19, 2023
3 tasks
Contributor
|
Merged to branch-0.7. |
jerqi
pushed a commit
that referenced
this pull request
May 19, 2023
…not closed (#882) ### What changes were proposed in this pull request? The container does not exit because shuffleclient is not closed ### Why are the changes needed? For #715 1.The process does not exit after the maptask or reducetask execution is complete. The reason is that ShuffleWriteClient has a thread pool that does not close when the task completes. So turning off ShuffleWriteClient can solve this problem. 2.How do I recreate this scene? Initialize a small cluster and submit an mr Task whose requested resources exceed the total resources in the cluster. We can see that all tasks have completed execution without quitting until the timeout time exceeds 60 seconds(mapreduce.task.exit.timeout). The appmaster requests the nodemanager to kill the corresponding container. The nodemanager logs are as follows `2023-03-12 13:56:45,901 INFO [AsyncDispatcher event handler] org.apache.hadoop.mapreduce.v2.app.job.impl.TaskAttemptImpl: Diagnostics report from attempt_1676901654399_1653119_m_000070_0: [2023-03-12 13:56:44.909]Container killed by the ApplicationMaster. [2023-03-12 13:56:44.921]Sent signal OUTPUT_THREAD_DUMP (SIGQUIT) to pid 45556 as user tc_infra for container container_e304_1676901654399_1653119_01_000072, result=success [2023-03-12 13:56:44.985]Container killed on request. Exit code is 143 [2023-03-12 13:56:45.403]Container exited with a non-zero exit code 143. ` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? existing UTs. Co-authored-by: zhaobing <zhaobing@zhihu.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The container does not exit because shuffleclient is not closed
Why are the changes needed?
For #715
1.The process does not exit after the maptask or reducetask execution is complete. The reason is that ShuffleWriteClient has a thread pool that does not close when the task completes. So turning off ShuffleWriteClient can solve this problem.
2.How do I recreate this scene?
Initialize a small cluster and submit an mr Task whose requested resources exceed the total resources in the cluster.
We can see that all tasks have completed execution without quitting until the timeout time exceeds 60 seconds(mapreduce.task.exit.timeout). The appmaster requests the nodemanager to kill the corresponding container.
The nodemanager logs are as follows
2023-03-12 13:56:45,901 INFO [AsyncDispatcher event handler] org.apache.hadoop.mapreduce.v2.app.job.impl.TaskAttemptImpl: Diagnostics report from attempt_1676901654399_1653119_m_000070_0: [2023-03-12 13:56:44.909]Container killed by the ApplicationMaster. [2023-03-12 13:56:44.921]Sent signal OUTPUT_THREAD_DUMP (SIGQUIT) to pid 45556 as user tc_infra for container container_e304_1676901654399_1653119_01_000072, result=success [2023-03-12 13:56:44.985]Container killed on request. Exit code is 143 [2023-03-12 13:56:45.403]Container exited with a non-zero exit code 143.Does this PR introduce any user-facing change?
No.
How was this patch tested?
existing UTs.