[#974] fix(coordinator): Dynamic remote storage conf invalid for LegacyClientConfParser
#1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @zuston , I am new here, would you take a look at this bug fix PR? Many thanks! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
============================================
+ Coverage 53.43% 54.38% +0.95%
- Complexity 2723 2729 +6
============================================
Files 419 399 -20
Lines 23992 21650 -2342
Branches 2046 2051 +5
============================================
- Hits 12820 11775 -1045
+ Misses 10378 9150 -1228
+ Partials 794 725 -69 ☔ View full report in Codecov by Sentry. |
LegacyClientConfParser
zuston
approved these changes
Jan 8, 2024
Member
|
Welcome to uniffle community! @myandpr |
Contributor
Author
Thanks for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As title
Why are the changes needed?
Fix: #974
Does this PR introduce any user-facing change?
Before:
rss.coordinator.remote.storage.cluster.conf hadoop-ns01,dfs.hosts=a,b,c,dfs.service=ssssswill trigger a bug.
After:
rss.coordinator.remote.storage.cluster.conf hadoop-ns01,dfs.hosts=a,b,c,dfs.service=ssssswill work correctly.
Yes.
How was this patch tested?
unit test