Skip to content

Conversation

@lifeSo
Copy link
Collaborator

@lifeSo lifeSo commented Dec 25, 2023

What changes were proposed in this pull request?

Add a similar util method like ThreadUtils.parmap in the Spark

Why are the changes needed?

Fix: #851

Does this PR introduce any user-facing change?

No.

How was this patch tested?

unit test

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (44fad8d) 53.23% compared to head (e9d5ec6) 54.14%.

Files Patch % Lines
...he/uniffle/client/impl/ShuffleWriteClientImpl.java 5.00% 38 Missing ⚠️
...va/org/apache/uniffle/common/util/ThreadUtils.java 50.00% 7 Missing ⚠️
...a/org/apache/uniffle/server/RegisterHeartBeat.java 58.33% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1396      +/-   ##
============================================
+ Coverage     53.23%   54.14%   +0.90%     
+ Complexity     2720     2719       -1     
============================================
  Files           419      399      -20     
  Lines         23994    21605    -2389     
  Branches       2051     2042       -9     
============================================
- Hits          12774    11698    -1076     
+ Misses        10427     9190    -1237     
+ Partials        793      717      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jerqi jerqi changed the title [851] improvement: Add a similar util method like ThreadUtils.parmap in the Spark —— test [851] [WIP] improvement: Add a similar util method like ThreadUtils.parmap in the Spark —— test Dec 25, 2023
@jerqi jerqi marked this pull request as draft December 25, 2023 03:11
@lifeSo lifeSo changed the title [851] [WIP] improvement: Add a similar util method like ThreadUtils.parmap in the Spark —— test [851] [WIP] improvement: Add a similar util method like ThreadUtils.parmap in the Spark Dec 25, 2023
@lifeSo lifeSo changed the title [851] [WIP] improvement: Add a similar util method like ThreadUtils.parmap in the Spark [851] improvement: Add a similar util method like ThreadUtils.parmap in the Spark Dec 25, 2023
@lifeSo lifeSo marked this pull request as ready for review December 25, 2023 17:00
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lifeSo

@jerqi jerqi merged commit 01925d2 into apache:master Dec 27, 2023
@jerqi
Copy link
Contributor

jerqi commented Dec 27, 2023

Merged to master.

@lifeSo lifeSo changed the title [851] improvement: Add a similar util method like ThreadUtils.parmap in the Spark [#851] improvement: Add a similar util method like ThreadUtils.parmap in the Spark Dec 27, 2023
@lifeSo lifeSo deleted the feature_851_-parmap branch December 30, 2023 21:28
zuston pushed a commit to zuston/incubator-uniffle that referenced this pull request Dec 31, 2023
…in the Spark (apache#1396)

### What changes were proposed in this pull request?

Add a similar util method like ThreadUtils.parmap in the Spark
### Why are the changes needed?

Fix: apache#851

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?
unit test
zuston pushed a commit to zuston/incubator-uniffle that referenced this pull request Mar 19, 2024
…in the Spark (apache#1396)

### What changes were proposed in this pull request?

Add a similar util method like ThreadUtils.parmap in the Spark
### Why are the changes needed?

Fix: apache#851

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?
unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Add a similar util method like ThreadUtils.parmap in the Spark

4 participants