Skip to content

Conversation

@xianjingfeng
Copy link
Member

What changes were proposed in this pull request?

Specify the version of goimports.

Why are the changes needed?

fix kubernetes ci pipeline.
https://github.com/apache/incubator-uniffle/actions/runs/7190065186/job/19582604526

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI passed.

@xianjingfeng xianjingfeng requested a review from jerqi December 13, 2023 05:45
Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecbf2e7) 53.22% compared to head (b4b6860) 53.25%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1368      +/-   ##
============================================
+ Coverage     53.22%   53.25%   +0.02%     
- Complexity     2715     2720       +5     
============================================
  Files           418      418              
  Lines         23932    23932              
  Branches       2043     2043              
============================================
+ Hits          12738    12745       +7     
+ Misses        10408    10402       -6     
+ Partials        786      785       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zuston zuston merged commit b2fe152 into apache:master Dec 13, 2023
xianjingfeng added a commit that referenced this pull request Dec 13, 2023
### What changes were proposed in this pull request?

Specify the version of `goimports`.

### Why are the changes needed?

fix kubernetes ci pipeline.
https://github.com/apache/incubator-uniffle/actions/runs/7190065186/job/19582604526

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI passed.

(cherry picked from commit b2fe152)
lifeSo added a commit to lifeSo/incubator-uniffle that referenced this pull request Dec 22, 2023
* master: (23 commits)
  format
  use synchronized
  format
  modify to singleton
  format
  format
  format
  format
  format
  change Coordinator to singleton like ShuffleServerClientFactory.java
  [apache#1189] feat(server): Add netty used direct memory size metric (apache#1363)
  format
  format
  format
  rename
  file rename
  [apache#960] fix(dashboard): simplify dependency and correct the startup script (apache#1347)
  [apache#1348] improvement(metrics): Unify tags generation for shuffle-server metrics reporter (apache#1349)
  [MINOR] chore: fix kubernetes ci pipeline (apache#1368)
  [MINOR] fix(spark): Fix NPE for ShuffleWriteClientImpl.unregisterShuffle (apache#1367)
  ...
lifeSo added a commit to lifeSo/incubator-uniffle that referenced this pull request Dec 26, 2023
…re_1119_new_2023_12_23

* feature_1119_BUFFER_LIMIT_OF_HUGE_PARTITION:
  add file for commit
  [apache#1189] feat(server): Add netty used direct memory size metric (apache#1363)
  format
  format
  format
  rename
  file rename
  [apache#960] fix(dashboard): simplify dependency and correct the startup script (apache#1347)
  [apache#1348] improvement(metrics): Unify tags generation for shuffle-server metrics reporter (apache#1349)
  [MINOR] chore: fix kubernetes ci pipeline (apache#1368)
  [MINOR] fix(spark): Fix NPE for ShuffleWriteClientImpl.unregisterShuffle (apache#1367)
  format code
  format code
  添加堆外内存监控的代码
zuston pushed a commit to zuston/incubator-uniffle that referenced this pull request Jan 18, 2024
### What changes were proposed in this pull request?

Specify the version of `goimports`.

### Why are the changes needed?

fix kubernetes ci pipeline.
https://github.com/apache/incubator-uniffle/actions/runs/7190065186/job/19582604526

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI passed.
@xianjingfeng xianjingfeng deleted the minor branch January 26, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants