-
Notifications
You must be signed in to change notification settings - Fork 168
[MINOR] chore: fix kubernetes ci pipeline #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zuston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
zuston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1368 +/- ##
============================================
+ Coverage 53.22% 53.25% +0.02%
- Complexity 2715 2720 +5
============================================
Files 418 418
Lines 23932 23932
Branches 2043 2043
============================================
+ Hits 12738 12745 +7
+ Misses 10408 10402 -6
+ Partials 786 785 -1 ☔ View full report in Codecov by Sentry. |
### What changes were proposed in this pull request? Specify the version of `goimports`. ### Why are the changes needed? fix kubernetes ci pipeline. https://github.com/apache/incubator-uniffle/actions/runs/7190065186/job/19582604526 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI passed. (cherry picked from commit b2fe152)
* master: (23 commits) format use synchronized format modify to singleton format format format format format change Coordinator to singleton like ShuffleServerClientFactory.java [apache#1189] feat(server): Add netty used direct memory size metric (apache#1363) format format format rename file rename [apache#960] fix(dashboard): simplify dependency and correct the startup script (apache#1347) [apache#1348] improvement(metrics): Unify tags generation for shuffle-server metrics reporter (apache#1349) [MINOR] chore: fix kubernetes ci pipeline (apache#1368) [MINOR] fix(spark): Fix NPE for ShuffleWriteClientImpl.unregisterShuffle (apache#1367) ...
…re_1119_new_2023_12_23 * feature_1119_BUFFER_LIMIT_OF_HUGE_PARTITION: add file for commit [apache#1189] feat(server): Add netty used direct memory size metric (apache#1363) format format format rename file rename [apache#960] fix(dashboard): simplify dependency and correct the startup script (apache#1347) [apache#1348] improvement(metrics): Unify tags generation for shuffle-server metrics reporter (apache#1349) [MINOR] chore: fix kubernetes ci pipeline (apache#1368) [MINOR] fix(spark): Fix NPE for ShuffleWriteClientImpl.unregisterShuffle (apache#1367) format code format code 添加堆外内存监控的代码
### What changes were proposed in this pull request? Specify the version of `goimports`. ### Why are the changes needed? fix kubernetes ci pipeline. https://github.com/apache/incubator-uniffle/actions/runs/7190065186/job/19582604526 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI passed.
What changes were proposed in this pull request?
Specify the version of
goimports.Why are the changes needed?
fix kubernetes ci pipeline.
https://github.com/apache/incubator-uniffle/actions/runs/7190065186/job/19582604526
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI passed.