Remove plugin parent_select unused symbols #9023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
approved these changes
Aug 10, 2022
zwoop
pushed a commit
that referenced
this pull request
Aug 23, 2022
(cherry picked from commit b477c8d)
Contributor
|
Cherry-picked to v9.2.x |
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Aug 23, 2022
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog utilize proxy.config.hostdb.host_file.interval config variable (apache#9039) Remove plugin parent_select unused symbols (apache#9023) Require use of 'override' keyword when valid. (apache#8737) Fix compile error on macOS (apache#9047) Validate that content length header matches object size on cache read (apache#8976) Fix reload memory leak (apache#9041) Update prepare_proxy_verifier.sh to work in non-git directories (apache#9048) Change linux/fs include to build with glibc 2.36 (apache#9027) ts::shared_mutex - Fix lock counting for debug (apache#9040)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
exclude_hostnameandexclude_portargs were needed due to limitations on events, the parent_select plugin needed to get the subsequent parent to try, if necessary, because no event would fire. So it needed to say, "give me the next parent if this one were marked down, even though it isn't."Their usage got lost in the parent_select consistent hash refactor (#8590), which I thought would break failover.
But I just extensively tested failover, for DNS, network, and internal code failures, and everything worked up to 3 tries. So it seems either #8590 (#7925 and #8365) or possibly the recent HostDB refactor (#8953) changed something to not make it necessary.
So this PR cleans up the parameters and variables, and just removes them entirely.
This is purely cleanup, doesn't affect behavior. But I recommend backporting to 9.2.x just to reduce future merge conflicts.