Add log field names pqu* and deprecates cqu* #9019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I had to update a binary test data, and I made the change like this. |
bneradt
approved these changes
Aug 15, 2022
maskit
added a commit
to maskit/trafficserver
that referenced
this pull request
Aug 15, 2024
This is for apache#9019 and apache#9258.
maskit
added a commit
to maskit/trafficserver
that referenced
this pull request
Aug 15, 2024
This is for apache#9019 and apache#9258.
bryancall
added a commit
to bryancall/trafficserver
that referenced
this pull request
Aug 15, 2024
maskit
added a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #8196, and the target branch is 10-Dev because it deprecates a couple of log fields.
#8015 corrected errors on the documentation, but the field names were kept as they are for compatibility. This PR deprecates the incorrectly named fields,
cpu,cquc,cqup, andcqus. And introducespqu,pquc,pqup, andpqusas replacements.I know variable names used in Log.cc still has "client_request" in their names and those should be renamed accordingly, but I wanted to make this field name change before it's too late since we can make this change only on a new major version release.