-
Notifications
You must be signed in to change notification settings - Fork 849
Adds a simple tool to generate new escape tables #8783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Add the binary to gitignore 2. Add a NOTE requesting changies to LogUtils.cc codes_to_escape to update the tool. 3. Convert escape_mapper to C++.
bneradt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just have a few minor suggestions. I made a PR for your fork with these suggestions here:
Feel free to pull that in, make changes, or discard it.
Some escape_mapper suggestions
Thanks for the assist; I just merged it in. I wrote this very quickly as a standalone tool, so I appreciate the help turning it into something that more closely resembles an existing ATS tools. |
bneradt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
* Adds a simple tool to generate new escape tables * Removed trailing whitespace from the README. * Some review suggestions: 1. Add the binary to gitignore 2. Add a NOTE requesting changies to LogUtils.cc codes_to_escape to update the tool. 3. Convert escape_mapper to C++. Co-authored-by: Brian Neradt <brian.neradt@gmail.com> (cherry picked from commit cdf0d49)
|
Cherry-picked to v9.2.x |
* asf/9.2.x: Updated ChangeLog HttpSM, HttpTunnel, and Http2Stream debug logging updates (apache#8788) Fix plugin parent_select failover (apache#8676) Adds new plugin, http_stats (apache#8797) SIGTERM should cause traffic_manager to exit with status 0 as a shutdown method (apache#8798) Avoid allocation when matching hosts for vol lookup (apache#8762) Check bounds before accessing Vol::evacuate array (apache#8716) Adds a simple tool to generate new escape tables (apache#8783)
No description provided.