Skip to content

Conversation

@elsloo
Copy link
Contributor

@elsloo elsloo commented Apr 6, 2022

No description provided.

@elsloo elsloo requested review from bryancall and zwoop as code owners April 6, 2022 00:19
@elsloo elsloo added the Tools label Apr 6, 2022
@randall randall added this to the 10.0.0 milestone Apr 8, 2022
@bryancall bryancall requested review from bneradt April 11, 2022 23:20
1. Add the binary to gitignore
2. Add a NOTE requesting changies to LogUtils.cc codes_to_escape to
   update the tool.
3. Convert escape_mapper to C++.
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just have a few minor suggestions. I made a PR for your fork with these suggestions here:

elsloo#1

Feel free to pull that in, make changes, or discard it.

@elsloo
Copy link
Contributor Author

elsloo commented Apr 18, 2022

Looks good. I just have a few minor suggestions. I made a PR for your fork with these suggestions here:

elsloo#1

Feel free to pull that in, make changes, or discard it.

Thanks for the assist; I just merged it in. I wrote this very quickly as a standalone tool, so I appreciate the help turning it into something that more closely resembles an existing ATS tools.

Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@elsloo elsloo merged commit cdf0d49 into apache:master Apr 18, 2022
zwoop pushed a commit that referenced this pull request Apr 20, 2022
* Adds a simple tool to generate new escape tables

* Removed trailing whitespace from the README.

* Some review suggestions:

1. Add the binary to gitignore
2. Add a NOTE requesting changies to LogUtils.cc codes_to_escape to
   update the tool.
3. Convert escape_mapper to C++.

Co-authored-by: Brian Neradt <brian.neradt@gmail.com>
(cherry picked from commit cdf0d49)
@zwoop
Copy link
Contributor

zwoop commented Apr 20, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Apr 20, 2022
moonchen pushed a commit to moonchen/trafficserver that referenced this pull request May 26, 2022
* asf/9.2.x:
  Updated ChangeLog
  HttpSM, HttpTunnel, and Http2Stream debug logging updates (apache#8788)
  Fix plugin parent_select failover (apache#8676)
  Adds new plugin, http_stats (apache#8797)
  SIGTERM should cause traffic_manager to exit with status 0 as a shutdown method (apache#8798)
  Avoid allocation when matching hosts for vol lookup (apache#8762)
  Check bounds before accessing Vol::evacuate array (apache#8716)
  Adds a simple tool to generate new escape tables (apache#8783)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants