Test: Make trafficserver ext test use runroot file by default. #8641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
[approve ci autest] |
…ill dump the file in the config folder by default, it can be disabled by parameter if needed. With this change I am also removing the need to specify the runroot file when calling traffic_ctl(jsonrpc). Base on this change all the tests were adjusted.
1e76a28 to
77427b8
Compare
77427b8 to
2f2a932
Compare
Contributor
Author
#8644 should fix this. I can rebase this PR after the other is merged in. |
bneradt
approved these changes
Feb 4, 2022
Contributor
|
[approve ci autest] |
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jul 7, 2022
…ill dump the file in the config folder by default, it can be disabled by parameter if needed. (apache#8641) With this change I am also removing the need to specify the runroot file when calling traffic_ctl(jsonrpc). Base on this change all the tests were adjusted. (cherry picked from commit 86549bf) Conflicts: doc/appendices/command-line/traffic_ctl_jsonrpc.en.rst tests/gold_tests/pluginTest/lua/lua_states_stats.test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this change is to let
traffic_serverandtraffic_ctluse therunrootfile by defaut in the tests, this can be disable when callingMakeATSProcesswithdump_runroot=False.This change also:
Note:
I am expecting the regex_revalidate_miss test to fail, it seems to be a transient error when updating the config file which is not picked up properly by the config reloader as the two versions shows the same timestamp. There is another PR to fix this.