-
Notifications
You must be signed in to change notification settings - Fork 849
Fixes compacting spaces in S3 auth plugin #8579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[approve ci ubuntu] |
duke8253
requested changes
Jan 5, 2022
cda2176 to
50510b9
Compare
duke8253
approved these changes
Jan 10, 2022
Contributor
Author
|
@duke8253 so what's gonna happen next? Do we wait for another review or is the change ready to merge? |
Contributor
|
Cherry-picked to v9.2.x for merge conflicts with #8638 |
zwoop
pushed a commit
that referenced
this pull request
Jul 7, 2022
Co-authored-by: Julian Rubin <julian.rubin@rtbhouse.com> (cherry picked from commit ca2a06e)
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog trim white spaces before and after the equal sign (apache#8638) Fixes compacting spaces in S3 auth plugin (apache#8579) Fixed issues when compiling with -Og (apache#8665) Update lua plugin examples (apache#8646) Additional helper functions for request transform (apache#8631) Move ChangeLog and README.md to the lib/fastlz/ (apache#8629) Remove unused functions/definitions from ink_defs (apache#8714) Stop ATS when a global lua script fails to load (apache#8671) Change DNS retries to be a static (requires restart) config value (apache#8724) add log format for whether origin TLS connection resumed an existing TLS session (apache#8745) Update location for core rule set in modsecurity example (apache#8924) Remove unnecessary use of a memory arena when logging. (apache#8925) Add docs for remap_stats plugin (apache#8927) Allows errors from plugin initialization to bubble up (apache#8926) proxy_serve_stale: Test updates (apache#8928) Make clang-format not modify ink_autoconf.h.in and ink_autoconf.h (apache#8935) Fix clang-format installation with multiple threads (apache#8931) Add nullptr check of HTTPInfo (apache#8937)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8583
Hi,
Here's a change that I believe fixes the #7888. Could you review it?