TS-4396: fix number_of_redirections off-by-one #786
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proxy/http/HttpSM.cc
Outdated
| } | ||
|
|
||
| redirection_tries++; | ||
|
|
Contributor
There was a problem hiding this comment.
Right below here, we repeat the test on number_of_redirections with is_redirect_required(). The condition is different however, since this code will not redirect withnumber_of_redirectionsandis_redirect_required()`` will.
I don't think that this is the right place to increment redirection_tries, though it is an improvement. How about incrementing it in redirect_request()? Or at least defer until we know we are actually going to call redirect_request.
We should restructure this function like this:
if (!is_redirect_required()) {
tunnel.deallocate_redirect_post_buffers();
enable_redirection = false;
return;
}
...
Member
Author
There was a problem hiding this comment.
hmm, looks like better to do redirection_tries++ when setting redirect_in_process = true, if you consider a really redirection. good catch.
Contributor
|
[approve ci] |
Contributor
|
Closing since there is a new PR for this #2092 |
bneradt
added a commit
to bneradt/trafficserver
that referenced
this pull request
Jul 12, 2024
* Http2 to origin This implements the HTTP/2 to origin feature. * Adding window size and flow control out parameters. * Handle set_connect_fail in ConnectingEntry correctly When ConnectingEntry handled a connection failure, it could clear the error value passed to set_connect_fail. This would incorrectly result in the server not being marked down by hostdb. This patch ensures that the error code passed to set_connect_fail is always an error value when handling a connection failure. * Send WINDOW_UPDATE for session when stream ends for other streams * pass through RST_STREAM frame * set_cause_of_death_errno * Http2 to origin fix (#4) * Fix for connection level window mismatch + force connection level window update * Fix for HPACK corruption on closed streams Todo: check stream level error returns, these should still decode the headers to prevent HPACK corruption for following header frames --------- Co-authored-by: Kees Spoelstra <kd.spoelstra@gmail.com> * proxy.config.exec_thread.autoconfig -> ''.enabled This is a changed needed to the new HTTP/2 to origin tests for the records.yaml update. * Revert a restart_receiving call causing POST issues The post-continue.test.py AuTest demonstrated that the restart_receiving call was causing the first 64KB of data from a POST to be lost. * Expand tunnel_handler to expect VC_EVENT_INACTIVITY_TIMEOUT The HttpSM::tunnel_handler expects the tunnel to be going away and asserts that the event it receives is HTTP_TUNNEL_EVENT_DONE. However, the tunnel can be going away due to timeout as well. Adding VC_EVENT_INACTIVITY_TIMEOUT as a possible event in that function. * remove the buffer reader from the consumer's vc Co-authored-by: Brian Neradt <brian.neradt@gmail.com> Co-authored-by: Fei Deng <feid@oath.com> Co-authored-by: keesspoelstra <kd.spoelstra+github@gmail.com> Co-authored-by: Kees Spoelstra <kd.spoelstra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please test