TS-4187: Keep the currently_open connections in sync with open sockets #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks good to me. I think it should be reasonable to construct a simple integration test for this? |
Member
Author
|
I think you could do a TSQA test. Configure with global pools. Run a set of requests through. Wait a while for things to drain out. Verify that the current_open connection count is 0 or really close to 0. I don't see how to do an integration test that would exercise this case. |
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Oct 6, 2021
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Nov 8, 2021
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Nov 9, 2021
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Nov 9, 2021
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Jan 24, 2022
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement on the original fix for TS-4187. The original fix would in some case over count the open sockets. It seems sometimes, the connection would have already been closed or rather be scheduled to be closed multiple times. We would increase the currently_open count for every scheduled close, but only decrease it for the actual free.
I've changed things around to decrease in the do_io_close if it is called with a valid file descriptor.
This seems to better keep the currently_open count in sync with the established socket count on the systems. However, both grow until we run out of memory on our production boxes. But that is being tracked by TS-4330