TS-4046: Prevent memory leak of HTTP heap for server intercept case. #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| inline void | ||
| HTTPHdr::clear() | ||
| HTTPHdr::destroy() |
Member
There was a problem hiding this comment.
I'm seeing several other usages of HTTPHdr::clear() such as:
Http2UpgradeContext::~Http2UpgradeContext()
HttpTransactCache::calculate_quality_of_match()
And HTTPHdr::unmarshal()
Am I missing something?
brbzull0
added a commit
to brbzull0/trafficserver
that referenced
this pull request
Oct 6, 2021
…a shared foler (apache#577) * [JSONRPC] - Move JSONRPC request/response definitions to a shared folder. - Split base request/response object into base objects and specific ones for traffic_ctl. - Add documentation. - Clean up some code in the RPC client code. * [JSONRPC] - rpc shared client, add invoke function that takes a JSONRPC object. * [JSONRPC] - fix typo * [JSONRPC] - rename namespace. Add default template type. * Fix typo in yaml_codecs.h Co-authored-by: Damian Meden <damian.meden@gmail.com>
brbzull0
added a commit
to brbzull0/trafficserver
that referenced
this pull request
Nov 8, 2021
…a shared foler (apache#577) * [JSONRPC] - Move JSONRPC request/response definitions to a shared folder. - Split base request/response object into base objects and specific ones for traffic_ctl. - Add documentation. - Clean up some code in the RPC client code. * [JSONRPC] - rpc shared client, add invoke function that takes a JSONRPC object. * [JSONRPC] - fix typo * [JSONRPC] - rename namespace. Add default template type. * Fix typo in yaml_codecs.h Co-authored-by: Damian Meden <damian.meden@gmail.com>
brbzull0
added a commit
to brbzull0/trafficserver
that referenced
this pull request
Nov 9, 2021
…a shared foler (apache#577) * [JSONRPC] - Move JSONRPC request/response definitions to a shared folder. - Split base request/response object into base objects and specific ones for traffic_ctl. - Add documentation. - Clean up some code in the RPC client code. * [JSONRPC] - rpc shared client, add invoke function that takes a JSONRPC object. * [JSONRPC] - fix typo * [JSONRPC] - rename namespace. Add default template type. * Fix typo in yaml_codecs.h Co-authored-by: Damian Meden <damian.meden@gmail.com>
brbzull0
added a commit
to brbzull0/trafficserver
that referenced
this pull request
Nov 9, 2021
…a shared foler (apache#577) * [JSONRPC] - Move JSONRPC request/response definitions to a shared folder. - Split base request/response object into base objects and specific ones for traffic_ctl. - Add documentation. - Clean up some code in the RPC client code. * [JSONRPC] - rpc shared client, add invoke function that takes a JSONRPC object. * [JSONRPC] - fix typo * [JSONRPC] - rename namespace. Add default template type. * Fix typo in yaml_codecs.h Co-authored-by: Damian Meden <damian.meden@gmail.com>
brbzull0
added a commit
to brbzull0/trafficserver
that referenced
this pull request
Jan 24, 2022
…a shared foler (apache#577) * [JSONRPC] - Move JSONRPC request/response definitions to a shared folder. - Split base request/response object into base objects and specific ones for traffic_ctl. - Add documentation. - Clean up some code in the RPC client code. * [JSONRPC] - rpc shared client, add invoke function that takes a JSONRPC object. * [JSONRPC] - fix typo * [JSONRPC] - rename namespace. Add default template type. * Fix typo in yaml_codecs.h Co-authored-by: Damian Meden <damian.meden@gmail.com>
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jul 7, 2022
…a shared foler (apache#577) * [JSONRPC] - Move JSONRPC request/response definitions to a shared folder. - Split base request/response object into base objects and specific ones for traffic_ctl. - Add documentation. - Clean up some code in the RPC client code. * [JSONRPC] - rpc shared client, add invoke function that takes a JSONRPC object. * [JSONRPC] - fix typo * [JSONRPC] - rename namespace. Add default template type. * Fix typo in yaml_codecs.h Co-authored-by: Damian Meden <damian.meden@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of an intercept plugin the
client_responsecan be leaked. I changed the method used to bedestroyto be clearer and changed it to destroy the heap, not just drop the pointers. This has been tested in production and should be isolated as there is only one place this method is invoked.