TS-4067: Memory leaks in parent selection regression tests. #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
This looks better. @jrushford can you please wrap these macros in a Could you consider rewriting these tests to be more structured and maintainable? |
Contributor
Author
|
@jpeach, I'll wrap these macros in the do {...} while(0) block, good idea. I'll think about the re-write in the future but, I have some other things that are higher priority. Are you +1 on landing this after the do {} while(0) changes? |
Contributor
|
Yes that sounds fine, thanks @jrushford |
1592fbc to
3b656d6
Compare
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Jan 9, 2018
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Oct 6, 2021
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Nov 8, 2021
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Nov 9, 2021
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Nov 9, 2021
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Jan 24, 2022
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed all of the memory leaks in the ParentSelection regression tests.