Skip to content

trafic_crashlog: Moving the removed ATS backtrace logs. #10811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brbzull0 merged 1 commit into from
Dec 5, 2023
Merged

trafic_crashlog: Moving the removed ATS backtrace logs. #10811

brbzull0 merged 1 commit into from
Dec 5, 2023

Conversation

@brbzull0
Copy link
Contributor

@brbzull0 brbzull0 commented Nov 17, 2023 •
edited
Loading

Moving the removed ATS backtrace logs from traffic_manager to traffic_crashlog.

Version:            Traffic Server 10.0.0
System Version:     Linux x86_64 #83~20.04.1-Ubuntu SMP Wed Jun 21 20:23:31 UTC 2023 5.15.0-76-generic
Date:               Fri, 17 Nov 2023 10:42:12 +0100

No target signal information

No target CPU registers

Thread 721278, [TS_MAIN]:
0    0x000055b8be517318 crash_logger_invoke(int, siginfo_t*, void*) + 0xab
1    0x00007f48c8a69420 funlockfile + 0x60
2    0x00007f48c893e23f clock_nanosleep + 0xdf
3    0x00007f48c8943ec7 nanosleep + 0x17
4    0x00007f48c8943dfe sleep + 0x3e
5    0x000055b8be52ce11 main + 0x2242
6    0x00007f48c8885083 __libc_start_main + 0xf3
7    0x000055b8be51677e _start + 0x2e

Thread 721280, traffic_server:
0    0x000055b8be98a485 bool (anonymous namespace)::poll_on_socket<rpc::comm::IPCSocketServer::poll_for_new_client(std::chrono::duration<long, std::ratio<1l, 1000l> >) const::{lambda(int)#1}&>(rpc::comm::IPCSocketServer::poll_for_new_client(std::chrono::duration<long, std::ratio<1l, 1000l> >) const::{lambda(int)#1}&, std::chrono::duration<long, std::ratio<1l, 1000l> >, int) + 0x51
1    0x000055b8be988e48 rpc::comm::IPCSocketServer::poll_for_new_client(std::chrono::duration<long, std::ratio<1l, 1000l> >) const + 0x48
2    0x000055b8be988f5b rpc::comm::IPCSocketServer::run() + 0xc5
3    0x000055b8be9872b8 rpc::RPCServer::run_thread(void*) + 0x6a
4    0x00007f48c8a5d609 start_thread + 0xd9
5    0x00007f48c8980133 clone + 0x43

Thread 721281, [ET_NET 0]:
0    0x000055b8be930fe3 PollCont::do_poll(long) + 0x157
1    0x000055b8be92dbfa NetHandler::waitForActivity(long) + 0x92
2    0x000055b8be973f24 EThread::execute_regular() + 0x446
3    0x000055b8be9740b1 EThread::execute() + 0xe3
4    0x000055b8be972b76 spawn_thread_internal(void*) + 0x81
5    0x00007f48c8a5d609 start_thread + 0xd9
6    0x00007f48c8980133 clone + 0x43

Thread 721282, [ET_TASK 0]:
0    0x000055b8be971de3 ink_cond_timedwait(pthread_cond_t*, pthread_mutex_t*, timespec*) + 0x2b
1    0x000055b8be972010 ProtectedQueue::wait(long) + 0x86
2    0x000055b8be97464e EThread::DefaultTailHandler::waitForActivity(long) + 0x34
3    0x000055b8be973f24 EThread::execute_regular() + 0x446
4    0x000055b8be9740b1 EThread::execute() + 0xe3
5    0x000055b8be972b76 spawn_thread_internal(void*) + 0x81
6    0x00007f48c8a5d609 start_thread + 0xd9
7    0x00007f48c8980133 clone + 0x43

Thread 721283, [ET_TASK 1]:
0    0x000055b8be971de3 ink_cond_timedwait(pthread_cond_t*, pthread_mutex_t*, timespec*) + 0x2b
1    0x000055b8be972010 ProtectedQueue::wait(long) + 0x86
2    0x000055b8be97464e EThread::DefaultTailHandler::waitForActivity(long) + 0x34
3    0x000055b8be973f24 EThread::execute_regular() + 0x446
4    0x000055b8be9740b1 EThread::execute() + 0xe3
5    0x000055b8be972b76 spawn_thread_internal(void*) + 0x81
6    0x00007f48c8a5d609 start_thread + 0xd9
7    0x00007f48c8980133 clone + 0x43
...

@brbzull0 brbzull0 self-assigned this Nov 17, 2023
brbzull0
brbzull0 commented Nov 17, 2023
View reviewed changes
src/traffic_crashlog/CMakeLists.txt Outdated
add_executable(traffic_crashlog procinfo.cc backtrace.cc traffic_crashlog.cc)

target_link_libraries(traffic_crashlog PRIVATE ts::inkevent ts::records ts::tscore ts::tsapicore)
target_link_libraries(traffic_crashlog PRIVATE ts::inkevent ts::records ts::tscore ts::tsapicore unwind::unwind)
Copy link
Contributor Author

@brbzull0 brbzull0 Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wont work, I had to manually add unwind-ptrace unwind-generic on my ubuntu 20.04.

Copy link
Contributor Author

@brbzull0 brbzull0 Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work now as.
Thanks @cmcfarlen for collaborating with this.

bneradt
bneradt requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on adding backtraces in.

@brbzull0 brbzull0 marked this pull request as ready for review November 20, 2023 12:45
@brbzull0
Copy link
Contributor Author

brbzull0 commented Nov 20, 2023 •
edited
Loading 

-- TS_USE_REMOTE_UNWINDING: FALSE (AUTO) (hint: add -DENABLE_UNWIND=ON to require)
..
-- 
-- Configuring done
CMake Error at src/traffic_crashlog/CMakeLists.txt:18 (add_executable):
  Target "traffic_crashlog" links to target "unwind::unwind" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?

seems that we try to link with the unwind namespace eventhough is not eabled.

fixed

@bneradt
Copy link
Contributor

bneradt commented Nov 21, 2023

[approve ci]

1 similar comment
@brbzull0
Copy link
Contributor Author

brbzull0 commented Nov 28, 2023

[approve ci]

@brbzull0
Copy link
Contributor Author

brbzull0 commented Nov 30, 2023

[approve ci rat]

@brbzull0 brbzull0 requested a review from bneradt December 5, 2023 16:44
@brbzull0 brbzull0 merged commit 9d9e72b into apache:master Dec 5, 2023
@brbzull0 brbzull0 mentioned this pull request Dec 5, 2023
Closed
2 tasks
@phongn phongn mentioned this pull request Jan 23, 2024
Merged
phongn pushed a commit to phongn/trafficserver that referenced this pull request Feb 1, 2024
@brbzull0 @phongn
trafic_crashlog: Moving the removed ATS backtrace logs from traffic_m…
4b0931c 
…anager to traffic_crashlog (apache#10811)
bneradt pushed a commit that referenced this pull request Feb 2, 2024
@phongn
Fix Findunwind.cmake on RHEL (#11001)
9d56432 
Fix change in #10811 intended for Ubuntu that caused build issues on RHEL.
@zwoop zwoop added this to the 10.0.0 milestone Feb 29, 2024
@bryancall bryancall mentioned this pull request Dec 11, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randall randall randall approved these changes

@bneradt bneradt bneradt approved these changes

@cmcfarlen cmcfarlen Awaiting requested review from cmcfarlen

Assignees

@brbzull0 brbzull0

Labels

None yet

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@brbzull0 @bneradt @randall @zwoop