STORM-549: "topology.enable.message.timeouts" does nothing#309
Merged
Conversation
Contributor
|
+1 |
Contributor
|
@SeanTAllen @harshach |
Contributor
Author
|
@HeartSaVioR merge it into my master and update the PR? |
Add unit test for disable tuple timeout (adding to #309)
Contributor
Author
|
@HeartSaVioR done |
Contributor
|
@SeanTAllen Thanks! |
Member
|
+1 |
1 similar comment
Contributor
|
+1 |
Member
|
Thanks @SeanTAllen. I merged this into master and 0.9.3. |
knusbaum
pushed a commit
to knusbaum/incubator-storm
that referenced
this pull request
Feb 11, 2015
[YSTORM-456] Fix nimbus logviewer forwarding bouncer cookie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ability to turn off message timeouts doesn't work.
The value is a true/false value that is represented as
a Java Boolean. The check for the truthiness used the
clojure not function. The idea was, turn off message
timeouts if "topology.enable.message.timeouts" is not true.
Unfortunately this won't worth with clojure's definition of
truthiness as:
(not (Boolean. false))
evaluates to true.
This commit updates the logic to compare the Java Boolean
"topology.enable.message.timeouts" to false using the
= function which will work.