[SPARK-54100][BUILD] Remove ignore.symbol.file Javac option#52802
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-54100][BUILD] Remove ignore.symbol.file Javac option#52802dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
ignore.symbol.file Javac option#52802dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Could you review this PR when you have some time, @LuciferYang ? |
HyukjinKwon
approved these changes
Oct 30, 2025
Member
Author
|
Thank you, @HyukjinKwon ! |
Member
Author
|
Merged to master. |
Contributor
|
late LGTM |
Member
Author
|
Thank you, @LuciferYang . |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? This PR aims to remove `ignore.symbol.file` Javac option. ### Why are the changes needed? Since Apache Spark 4.0.0, we are building with `-release` which means `Javac` always uses `ct.sym`, a stripped-down version of the standard library (like rt.jar in older JDKs) containing only the necessary class stubs and signature data for the documented APIs of a specific Java release. In other words, `ignore.symbol.file` option is ignored now and we can remove it safely. - apache#45716 ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. **BEFORE** ``` $ git grep ignore.symbol.file | wc -l 4 ``` **AFTER** ``` $ git grep ignore.symbol.file | wc -l 0 ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52802 from dongjoon-hyun/SPARK-54100. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove
ignore.symbol.fileJavac option.Why are the changes needed?
Since Apache Spark 4.0.0, we are building with
-releasewhich meansJavacalways usesct.sym, a stripped-down version of the standard library (like rt.jar in older JDKs) containing only the necessary class stubs and signature data for the documented APIs of a specific Java release. In other words,ignore.symbol.fileoption is ignored now and we can remove it safely.-releaseinstead of-target#45716Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Pass the CIs.
BEFORE
AFTER
Was this patch authored or co-authored using generative AI tooling?
No.