[SPARK-50098][PYTHON][FOLLOWUP] Update _minimum_googleapis_common_protos_version in setup.py#48643
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-50098][PYTHON][FOLLOWUP] Update _minimum_googleapis_common_protos_version in setup.py#48643dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
_minimum_googleapis_common_protos_version in setup.py#48643dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
…otos_version` in `setup.py`
Member
Author
|
Could you review this follow-up, @viirya ? |
Member
Author
|
All tests passed. |
viirya
approved these changes
Oct 24, 2024
Member
|
Thanks @dongjoon-hyun |
Member
Author
|
Thank you, @viirya ! |
Member
Author
|
This is only a follow-up to make it sure the enforcement logic. The dependency was updated and tested already in the previous PR. Let me merge this~ |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 24, 2025
…otos_version in setup.py for pyspark-client ### What changes were proposed in this pull request? This PR is a followup of #48643 that updates _minimum_googleapis_common_protos_version in setup.py for pyspark-client ### Why are the changes needed? To match the version with pyspark. ### Does this PR introduce _any_ user-facing change? No, `pyspark-client` has not been released yet. ### How was this patch tested? It will be tested in "Debug Build / Spark Connect Python-only (master, Python 3.11) " build. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50063 from HyukjinKwon/SPARK-50098-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Feb 24, 2025
…otos_version in setup.py for pyspark-client ### What changes were proposed in this pull request? This PR is a followup of #48643 that updates _minimum_googleapis_common_protos_version in setup.py for pyspark-client ### Why are the changes needed? To match the version with pyspark. ### Does this PR introduce _any_ user-facing change? No, `pyspark-client` has not been released yet. ### How was this patch tested? It will be tested in "Debug Build / Spark Connect Python-only (master, Python 3.11) " build. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50063 from HyukjinKwon/SPARK-50098-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit a084d64) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…otos_version in setup.py for pyspark-client ### What changes were proposed in this pull request? This PR is a followup of apache#48643 that updates _minimum_googleapis_common_protos_version in setup.py for pyspark-client ### Why are the changes needed? To match the version with pyspark. ### Does this PR introduce _any_ user-facing change? No, `pyspark-client` has not been released yet. ### How was this patch tested? It will be tested in "Debug Build / Spark Connect Python-only (master, Python 3.11) " build. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50063 from HyukjinKwon/SPARK-50098-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 2151085) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of
googleapis-common-protosto 1.65.0 #48638Why are the changes needed?
To be consistent.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.