[SPARK-44089][SQL][TESTS] Remove the @ignore identifier from AlterTableRenamePartitionSuite#41647
Closed
LuciferYang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-44089][SQL][TESTS] Remove the @ignore identifier from AlterTableRenamePartitionSuite#41647LuciferYang wants to merge 1 commit intoapache:masterfrom
@ignore identifier from AlterTableRenamePartitionSuite#41647LuciferYang wants to merge 1 commit intoapache:masterfrom
Conversation
@ignore annotation from AlterTableRenamePartitionSuite@ignore identifier from AlterTableRenamePartitionSuite
dongjoon-hyun
approved these changes
Jun 18, 2023
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making this PR, @LuciferYang .
+1, LGTM (Pending CIs).
zhengruifeng
approved these changes
Jun 18, 2023
MaxGekk
approved these changes
Jun 18, 2023
Member
|
+1, LGTM. Merging to master. |
Contributor
Author
|
Thanks @MaxGekk @dongjoon-hyun @zhengruifeng |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 19, 2023
…TableRenamePartitionSuite` ### What changes were proposed in this pull request? apache#41533 ignore `AlterTableRenamePartitionSuite` try to restore stability of `sql-others` test task, but it seems that it is not the root cause that affects stability, so this pr has removed the previously added `ignore` identifier to restore testing. ### Why are the changes needed? Resume testing of `AlterTableRenamePartitionSuite` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? should monitor ci Closes apache#41647 from LuciferYang/SPARK-44089. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#41533 ignore
AlterTableRenamePartitionSuitetry to restore stability ofsql-otherstest task, but it seems that it is not the root cause that affects stability, so this pr has removed the previously added@ignoreidentifier to restore testing.Why are the changes needed?
Resume testing of
AlterTableRenamePartitionSuiteDoes this PR introduce any user-facing change?
No
How was this patch tested?
should monitor ci