Skip to content

[SPARK-12187] *MemoryPool classes should not be fully public #10182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrewor14 wants to merge 2 commits into from
Closed

[SPARK-12187] *MemoryPool classes should not be fully public #10182

andrewor14 wants to merge 2 commits into from

Conversation

@andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Dec 8, 2015

This patch tightens them to private[memory].

@JoshRosen
Copy link
Contributor

JoshRosen commented Dec 8, 2015

LGTM.

@SparkQA
Copy link

SparkQA commented Dec 8, 2015

Test build #47294 has finished for PR 10182 at commit c0e16ad.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Dec 8, 2015
@JoshRosen
[SPARK-12187] *MemoryPool classes should not be fully public
25249d1 
This patch tightens them to `private[memory]`.

Author: Andrew Or <andrew@databricks.com>

Closes #10182 from andrewor14/memory-visibility.

(cherry picked from commit 9494521)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
@asfgit asfgit closed this in 9494521 Dec 8, 2015
@andrewor14 andrewor14 deleted the memory-visibility branch December 9, 2015 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewor14 @JoshRosen @SparkQA