Skip to content

Fix build-proxy-native-image job on Nightly Build#25632

Merged
terrymanu merged 1 commit into
apache:masterfrom
linghengqian:fix-nightly-build
May 13, 2023
Merged

Fix build-proxy-native-image job on Nightly Build#25632
terrymanu merged 1 commit into
apache:masterfrom
linghengqian:fix-nightly-build

Conversation

@linghengqian

@linghengqian linghengqian commented May 12, 2023

Copy link
Copy Markdown
Member

For #25509.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian changed the title Fix build-proxy-native-image on Nightly Build Fix build-proxy-native-image job on Nightly Build May 12, 2023
@linghengqian linghengqian force-pushed the fix-nightly-build branch 10 times, most recently from 84aa0a8 to 6ff6d9c Compare May 12, 2023 18:28

@linghengqian linghengqian left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I tested ./mvnw -PgenerateStandardMetadata -DskipNativeTests -B -T1C clean test and ./mvnw -am -pl distribution/proxy-native -B -T1C -Prelease.native -DskipTests clean package, it has returned to normal.
  • image

@linghengqian linghengqian marked this pull request as ready for review May 13, 2023 04:01

@linghengqian linghengqian left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The unit tests at org.apache.shardingsphere.infra.expr.espresso.EspressoInlineExpressionParserTest work fine when executed individually, but deadlock and eventually time out when executed in parallel. I think this is related to oracle/graal/pull/6599 and oracle/graal/pull/6512 for GraalVM CE 23.0 Dev.

  • I will introduce the SPI implementation of Trffule JS to avoid this problem until GraalVM CE 23.0 is released.

@linghengqian linghengqian requested a review from terrymanu May 13, 2023 04:23
@terrymanu terrymanu added this to the 5.4.0 milestone May 13, 2023
@terrymanu terrymanu merged commit 4e862ce into apache:master May 13, 2023
@linghengqian linghengqian deleted the fix-nightly-build branch May 13, 2023 13:19
kyooosukedn pushed a commit to kyooosukedn/shardingsphere that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants