Skip to content

Update library to serve building GraalVM Native Image#21571

Merged
terrymanu merged 3 commits into
apache:masterfrom
linghengqian:graalvm-metadata
Oct 18, 2022
Merged

Update library to serve building GraalVM Native Image#21571
terrymanu merged 3 commits into
apache:masterfrom
linghengqian:graalvm-metadata

Conversation

@linghengqian

@linghengqian linghengqian commented Oct 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

For #21347.

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

This was referenced Oct 14, 2022
Closed
Closed
@codecov-commenter

codecov-commenter commented Oct 15, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #21571 (e63f8ec) into master (43254b9) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master   #21571      +/-   ##
============================================
+ Coverage     61.05%   61.06%   +0.01%     
- Complexity     2509     2511       +2     
============================================
  Files          4111     4111              
  Lines         57295    57270      -25     
  Branches       7588     7587       -1     
============================================
- Hits          34979    34972       -7     
+ Misses        19381    19363      -18     
  Partials       2935     2935
Impacted Files Coverage Δ
...line/core/api/impl/AbstractPipelineJobAPIImpl.java 0.00% <ø> (ø)
...e/mode/repository/cluster/etcd/EtcdRepository.java 56.96% <50.00%> (+1.26%) ⬆️
...ndler/impl/BarrierMetaDataChangedEventHandler.java 20.00% <0.00%> (-13.34%) ⬇️
...ReplicationDatabaseDiscoveryProviderAlgorithm.java 26.31% <0.00%> (-3.69%) ⬇️
.../packet/binlog/AbstractMySQLBinlogEventPacket.java 66.66% <0.00%> (-3.34%) ⬇️
...distsql/rdl/rule/RuleDefinitionBackendHandler.java 74.46% <0.00%> (-3.09%) ⬇️
...channel/memory/MultiplexMemoryPipelineChannel.java 17.39% <0.00%> (-1.76%) ⬇️
...ipeline/postgresql/ingest/PostgreSQLWalDumper.java 78.57% <0.00%> (-0.74%) ⬇️
...agent/metrics/api/advice/ChannelHandlerAdvice.java 91.66% <0.00%> (-0.65%) ⬇️
...ReplicationDatabaseDiscoveryProviderAlgorithm.java 67.30% <0.00%> (-0.62%) ⬇️
... and 25 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@linghengqian linghengqian force-pushed the graalvm-metadata branch 6 times, most recently from 68cc6fe to b456187 Compare October 15, 2022 05:31
@linghengqian linghengqian marked this pull request as ready for review October 15, 2022 07:17
terrymanu
terrymanu reviewed Oct 15, 2022
View reviewed changes
Comment thread pom.xml
Comment thread pom.xml
@linghengqian

linghengqian commented Oct 17, 2022

Copy link
Copy Markdown
Member Author

@linghengqian

linghengqian commented Oct 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author
  • I have a local PR with the Conditional Agent Mode of GraalVM Native Build Tools, and its content is strongly related to the dependency version number. I am not sure if I should merge the content of these two PRs, or make another draft PR for review ? 🧐
  • Or should I upgrade HikariCP's version number dependency in this PR and fix the problem caused by its breaking changes, and separate the HikariCP version used by distribution/proxy and distribution/proxy-native? It sounds like the first thing that needs to be added in a separate PR or this PR is what is requested by Make ShardingSphere Proxy in GraalVM Native Image form available #21347 (comment) .

@terrymanu

terrymanu commented Oct 18, 2022

Copy link
Copy Markdown
Member
  • I have a local PR with the Conditional Agent Mode of GraalVM Native Build Tools, and its content is strongly related to the dependency version number. I am not sure if I should merge the content of these two PRs, or make another draft PR for review ? 🧐
  • Or should I upgrade HikariCP's version number dependency in this PR and fix the problem caused by its breaking changes, and separate the HikariCP version used by distribution/proxy and distribution/proxy-native? It sounds like the first thing that needs to be added in a separate PR or this PR is what is requested by Make ShardingSphere Proxy in GraalVM Native Image form available #21347 (comment) .

Great, I will review soon

@terrymanu terrymanu merged commit bded970 into apache:master Oct 18, 2022
@terrymanu terrymanu added this to the 5.2.2 milestone Oct 18, 2022
@linghengqian linghengqian deleted the graalvm-metadata branch October 18, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terrymanu terrymanu terrymanu approved these changes

Assignees

No one assigned

Labels

type: build

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@linghengqian @codecov-commenter @terrymanu