Automatically generate native-image conditional metadata for ChannelHandler implementations.#12794
Merged
chrisvest merged 2 commits intoSep 26, 2022
Merged
Conversation
Member
|
It ran into this failure in the Java 11 Graal build: |
Contributor
Author
|
@chrisvest Thank you for looking into this :) |
217efe1 to
21787a8
Compare
chrisvest
approved these changes
Sep 26, 2022
Member
|
Thanks! |
Contributor
Author
|
Thank you very much for merging this! :) Sorry for not looking into this PR further earlier, I think it was stuck on some transient issue - I had rebased it and re-run the workflows and they've passed |
This was referenced Oct 13, 2022
This was referenced Oct 25, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Analogous to #12738, this PR introduces automatic conditional native-image metadata generation for different ChannelHandler implementations
Modification:
This PR is basically the same as #12738, but adapted to conform to the Java language level 6.
This PR also adds the metadata generation to more subprojects that contain ChannelHandler implementations.
Result:
Fixes #12725